Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: do not change the profile to a none existing profile #6774

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Fix: do not change the profile to a none existing profile #6774

merged 2 commits into from
Feb 28, 2020

Conversation

vikkyomkar
Copy link
Contributor

This PR fixes bug of switching to non existing Minikube profile
Fixes #6767

(base) vikky$ ./out/minikube profile
minikube

(base) vikky$ ./out/minikube profile lis
❌ profile "lis" not found
❌ if you want to create a profile you can by this command: minikube start -p lis

(base) vikkyq$ ./out/minikube profile
minikube

(base) vikky$ ./out/minikube docker-env
export DOCKER_TLS_VERIFY="1"
export DOCKER_HOST="tcp://192.168.99.100:2376"
export DOCKER_CERT_PATH="/Users/vikky/.minikube/certs"
export MINIKUBE_ACTIVE_DOCKERD="minikube"`

To point your shell to minikube's docker-daemon, run:
eval $(minikube -p minikube docker-env)

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 24, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @vikkyomkar!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @vikkyomkar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 24, 2020
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #6774 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6774      +/-   ##
==========================================
- Coverage   38.62%   38.62%   -0.01%     
==========================================
  Files         142      142              
  Lines        8662     8663       +1     
==========================================
  Hits         3346     3346              
- Misses       4897     4898       +1     
  Partials      419      419
Impacted Files Coverage Δ
cmd/minikube/cmd/config/profile.go 0% <0%> (ø) ⬆️

@vikkyomkar
Copy link
Contributor Author

/check-cla

@medyagh
Copy link
Member

medyagh commented Feb 24, 2020

@vikkyomkar welcome to minikube contributors. Please make sure you have signed the CLA

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are at it, Could you please change the emoji icon for this

"❌ if you want to create a profile you can by this command: minikube start -p lis"

Maybe choose a better than x
Maybe info or something that we don't see to X in a row in terminal

@vikkyomkar
Copy link
Contributor Author

While we are at it, Could you please change the emoji icon for this

"❌ if you want to create a profile you can by this command: minikube start -p lis"

Maybe choose a better than x
Maybe info or something that we don't see to X in a row in terminal

Thanks. @medyagh ... How about using something like below
❌ profile "test" not found
💡 if you want to create a profile you can by this command: minikube start -p test

@medyagh
Copy link
Member

medyagh commented Feb 24, 2020

While we are at it, Could you please change the emoji icon for this
"❌ if you want to create a profile you can by this command: minikube start -p lis"
Maybe choose a better than x
Maybe info or something that we don't see to X in a row in terminal

Thanks. @medyagh ... How about using something like below
❌ profile "test" not found
💡 if you want to create a profile you can by this command: minikube start -p test

that looks perfect ! thank you

@medyagh
Copy link
Member

medyagh commented Feb 24, 2020

@vikkyomkar please make sure the CLA is signed, so we could merge this PR . thank you :)

@vikkyomkar
Copy link
Contributor Author

I tried to sign CLA but getting some error.
Will raise a help ticket to fix it and sign CLA ASAP

@medyagh
Copy link
Member

medyagh commented Feb 25, 2020

@vikkyomkar please make sure you have signed the CLA with the same email with your github here, https://identity.linuxfoundation.org/projects/cncf

without that we can not merge this.

@vikkyomkar
Copy link
Contributor Author

vikkyomkar commented Feb 26, 2020

@medyagh i followed the documentation to sign CLA using my github mail id...getting below message but didn't receive any validation mail..Also, I have raised a support ticket for this issue
https://jira.linuxfoundation.org/servicedesk/customer/portal/4/SUPPORT-946

image

@RA489
Copy link

RA489 commented Feb 26, 2020

/check-cla

1 similar comment
@vikkyomkar
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 28, 2020
@vikkyomkar
Copy link
Contributor Author

@medyagh finally i could sign CLA.
Can you please merge the PR now ?

@RA489
Copy link

RA489 commented Feb 28, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RA489, vikkyomkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2020
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you for this contribution, This will improve minikube users experience :)

@medyagh medyagh changed the title Fix: Minikube should not change the profile to a not existing profile Fix: ninikube should not change the profile to a not existing profile Feb 28, 2020
@medyagh medyagh changed the title Fix: ninikube should not change the profile to a not existing profile Fix: do not change the profile to a none existing profile Feb 28, 2020
@medyagh medyagh merged commit 3f34e68 into kubernetes:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minikube should not change the profile to a not existing profile
6 participants