-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make eviction and image GC settings consistent across kubeadm API versions #7364
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #7364 +/- ##
==========================================
+ Coverage 37.11% 37.18% +0.07%
==========================================
Files 145 145
Lines 8772 8836 +64
==========================================
+ Hits 3256 3286 +30
- Misses 5120 5154 +34
Partials 396 396
|
Error: running mkcmp: exit status 1 |
Error: running mkcmp: exit status 1 |
Error: running mkcmp: exit status 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, though we may need to revisit these settings later.
This PR: