Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make eviction and image GC settings consistent across kubeadm API versions #7364

Merged
merged 14 commits into from
Apr 2, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Apr 1, 2020

This PR:

  • makes GH none failures Zero
  • reduces GH docker driver failures from 20 to 9

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 1, 2020
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 1, 2020
@medyagh
Copy link
Member Author

medyagh commented Apr 1, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 1, 2020
@codecov-io
Copy link

codecov-io commented Apr 1, 2020

Codecov Report

Merging #7364 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7364      +/-   ##
==========================================
+ Coverage   37.11%   37.18%   +0.07%     
==========================================
  Files         145      145              
  Lines        8772     8836      +64     
==========================================
+ Hits         3256     3286      +30     
- Misses       5120     5154      +34     
  Partials      396      396              
Impacted Files Coverage Δ
pkg/minikube/problem/problem.go 89.79% <0.00%> (-5.95%) ⬇️
cmd/minikube/cmd/start.go 34.60% <0.00%> (-1.05%) ⬇️
cmd/minikube/cmd/dashboard.go 1.98% <0.00%> (-0.09%) ⬇️
cmd/minikube/cmd/kubectl.go 0.00% <0.00%> (ø)
pkg/minikube/machine/cache_images.go 0.00% <0.00%> (ø)
cmd/minikube/cmd/node_start.go 22.22% <0.00%> (+2.22%) ⬆️
cmd/minikube/cmd/node_add.go 25.00% <0.00%> (+3.26%) ⬆️
cmd/minikube/cmd/version.go 11.53% <0.00%> (+11.53%) ⬆️
pkg/minikube/localpath/localpath.go 53.73% <0.00%> (+38.57%) ⬆️

@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 2, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 2, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@medyagh medyagh changed the title adjust eviction hard and soft for both v1beta1 and v1beta2 adjust eviction for both v1beta1 and v1beta2 Apr 2, 2020
@medyagh medyagh changed the title adjust eviction for both v1beta1 and v1beta2 adjust missing eviction for v1beta2 Apr 2, 2020
@medyagh medyagh changed the title adjust missing eviction for v1beta2 adjust missing kubelet eviction for v1beta2 Apr 2, 2020
@medyagh medyagh changed the title adjust missing kubelet eviction for v1beta2 add missing kubelet eviction for v1beta2 Apr 2, 2020
Copy link
Contributor

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, though we may need to revisit these settings later.

@tstromberg tstromberg merged commit bf0bb60 into kubernetes:master Apr 2, 2020
@tstromberg tstromberg changed the title add missing kubelet eviction for v1beta2 Make eviction and image GC settings consistent across kubeadm API versions Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants