Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added deprecation warning for --network-plugin=cni #9368

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Added deprecation warning for --network-plugin=cni #9368

merged 1 commit into from
Oct 21, 2020

Conversation

kadern0
Copy link
Contributor

@kadern0 kadern0 commented Oct 1, 2020 •
edited
Loading

Signed-off-by: Pablo Caderno kaderno@gmail.com
Fixes #8445

@tstromberg please have a look and let me know if the message is OK.

Before start message:

./out/minikube start -p test --network-plugin=cni 
😄  [test] minikube v1.13.1 on Ubuntu 20.04
    ▪ MINIKUBE_ACTIVE_DOCKERD=minikube
✨  Automatically selected the docker driver. Other choices: kvm2, virtualbox
👍  Starting control plane node test in cluster test
🔥  Creating docker container (CPUs=2, Memory=3900MB) ...
🐳  Preparing Kubernetes v1.19.2 on Docker 19.03.8 ...
🔎  Verifying Kubernetes components...
🌟  Enabled addons: storage-provisioner, default-storageclass

❗  /usr/local/bin/kubectl is version 1.17.2, which may have incompatibilites with Kubernetes 1.19.2.
💡  Want kubectl v1.19.2? Try 'minikube kubectl -- get pods -A'
🏄  Done! kubectl is now configured to use "test" by default

After start message:

 ./out/minikube start -p test --network-plugin=cni 
😄  [test] minikube v1.13.1 on Ubuntu 20.04
    ▪ MINIKUBE_ACTIVE_DOCKERD=minikube
✨  Automatically selected the docker driver. Other choices: kvm2, virtualbox
❗  Found deprecated --network-plugin=cni flag (new flag: --cni), setting --cni=auto if not already set
👍  Starting control plane node test in cluster test
🔥  Creating docker container (CPUs=2, Memory=3900MB) ...
🐳  Preparing Kubernetes v1.19.2 on Docker 19.03.8 ...
🔎  Verifying Kubernetes components...
🌟  Enabled addons: storage-provisioner, default-storageclass

❗  /usr/local/bin/kubectl is version 1.17.2, which may have incompatibilites with Kubernetes 1.19.2.
💡  Want kubectl v1.19.2? Try 'minikube kubectl -- get pods -A'
🏄  Done! kubectl is now configured to use "test" by default

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 1, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @kadern0. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 1, 2020
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

medyagh
medyagh requested changes Oct 1, 2020
View reviewed changes
cmd/minikube/cmd/start_flags.go Outdated Show resolved Hide resolved
tstromberg
tstromberg reviewed Oct 9, 2020
View reviewed changes
cmd/minikube/cmd/start_flags.go Outdated
// networkPlugin cni deprecation warning
chosenNetworkPlugin := viper.GetString(networkPlugin)
if chosenNetworkPlugin == "cni" {
out.WarningT("Found deprecated --network-plugin=cni flag (new flag: --cni), setting --cni=auto if not already set")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misspoke in the original bug report, the actual deprecated flag was --enable-default-cni, checked above this. --network-plugin is still a necessary evil for some cases.

Could you change the warning to say something more like:

With --network-plugin=cni, you will need to provide your own CNI. See --cni flag as a user-friendly alternative

I would minikube not suddenly change the behavior of existing users of --network-plugin=cni if it can be avoided.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just updated the code.

@kadern0
Add warning for --network-plugin=cni (CNI has to be provided, see --cni)
1d85d6e 
Signed-off-by: Pablo Caderno <kaderno@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 12, 2020
@tstromberg
Copy link
Contributor

Thank you!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadern0, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2020
@tstromberg tstromberg merged commit dedf38b into kubernetes:master Oct 21, 2020
@fmotrifork fmotrifork mentioned this pull request Oct 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh requested changes

@tstromberg tstromberg tstromberg approved these changes

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add warning for --network-plugin=cni (CNI has to be provided, see --cni)
5 participants
@kadern0 @k8s-ci-robot @minikube-bot @tstromberg @medyagh