Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steering Committee has approval rights on SIG team membership #637

Closed
justaugustus opened this issue Mar 20, 2019 · 6 comments
Closed

Steering Committee has approval rights on SIG team membership #637

justaugustus opened this issue Mar 20, 2019 · 6 comments
Labels
committee/steering Denotes an issue or PR intended to be handled by the steering committee.

Comments

@justaugustus
Copy link
Member

Organization or repository

kubernetes/org

Users affected

All (@kubernetes/owners)

Describe the issue

While looking at #636, I noticed that the PR was already approved and merged, but by a non-SIG Release Chair/Lead.

I retroactively approved the PR, to make it clear that we're fine with the change, but I'd like to discuss a little. @timothysc was able to approve as he's part of Steering, which is listed as a root approver for k/org. I already chatted with Tim offline, and he said to definitely file an issue for this.

Do we want this?
As SIGs should be responsible for organizing themselves and Steering is really supposed to be an approver/denier of last resort, I think that we should either:

@timothysc
Copy link
Member

/cc @kubernetes/steering-committee

@justaugustus
Copy link
Member Author

/area github-management
/committee steering

@k8s-ci-robot k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Mar 20, 2019
@spiffxp
Copy link
Member

spiffxp commented Mar 20, 2019

I'm a pretty strong nope on no_parent_owners in this case, because the buck stops with the github admins here.

Removing steering from root instead

@spiffxp
Copy link
Member

spiffxp commented Mar 20, 2019

FWIW: whether membership into that team should be approvable by more than sig-release is orthogonal to steering being at root, that can definitely be represented in other ways, but I consider out of scope in this issue

@justaugustus
Copy link
Member Author

SGTM on all points. Thanks for addressing, @spiffxp!
Closed via #638.
/close

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closing this issue.

In response to this:

SGTM on all points. Thanks for addressing, @spiffxp!
Closed via #638.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
committee/steering Denotes an issue or PR intended to be handled by the steering committee.
Projects
None yet
Development

No branches or pull requests

4 participants