-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Steering Committee has approval rights on SIG team membership #637
Comments
/cc @kubernetes/steering-committee |
/area github-management |
I'm a pretty strong nope on Removing steering from root instead |
FWIW: whether membership into that team should be approvable by more than sig-release is orthogonal to steering being at root, that can definitely be represented in other ways, but I consider out of scope in this issue |
@justaugustus: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Organization or repository
kubernetes/org
Users affected
All (@kubernetes/owners)
Describe the issue
While looking at #636, I noticed that the PR was already approved and merged, but by a non-SIG Release Chair/Lead.
I retroactively approved the PR, to make it clear that we're fine with the change, but I'd like to discuss a little. @timothysc was able to approve as he's part of Steering, which is listed as a root approver for k/org. I already chatted with Tim offline, and he said to definitely file an issue for this.
Do we want this?
As SIGs should be responsible for organizing themselves and Steering is really supposed to be an approver/denier of last resort, I think that we should either:
no_parent_owners: true
in SIG OWNERS filesThe text was updated successfully, but these errors were encountered: