Quarterly SIG Release teams update #1205
Conversation
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
sig/release
|
@justaugustus: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/L
|
/test pull-org-test-all |
|
@cpanato -- hang on. There are some errors to fix: FAIL: //config:go_default_test (see /root/.cache/bazel/_bazel_root/e50ebc2a7cac8d93968e5988863c67ce/execroot/io_k8s_org/bazel-out/k8-fastbuild/testlogs/config/go_default_test/test.log)
INFO: From Testing //config:go_default_test:
==================== Test output for //config:go_default_test:
--- FAIL: TestAllOrgs (0.21s)
config_test.go:250: The team release-engineering in org Kubernetes has an unsorted list of members
config_test.go:250: The team sig-release in org Kubernetes has org admins listed as members; these users should be in the maintainers list instead, and cannot be on the members list: nikhita
config_test.go:250: The team sig-release in org Kubernetes has an unsorted list of members
config_test.go:250: The team milestone-maintainers in org Kubernetes has an unsorted list of members
FAIL |
justaugustus
force-pushed
the
sig-release
branch
from
d2c063c to
782ddae
Compare
|
Hmmm, I wonder if this new failure is transient... INFO: Call stack for the definition of repository 'zlib' which is a http_archive (rule definition at /root/.cache/bazel/_bazel_root/e50ebc2a7cac8d93968e5988863c67ce/external/bazel_tools/tools/build_defs/repo/http.bzl:237:16):
- /root/.cache/bazel/_bazel_root/e50ebc2a7cac8d93968e5988863c67ce/external/com_google_protobuf/protobuf_deps.bzl:9:9
- /home/prow/go/src/github.com/kubernetes/org/WORKSPACE:102:1
ERROR: An error occurred during the fetch of repository 'zlib':
java.io.IOException: Error downloading [https://zlib.net/zlib-1.2.11.tar.gz] to /root/.cache/bazel/_bazel_root/e50ebc2a7cac8d93968e5988863c67ce/external/zlib/zlib-1.2.11.tar.gz: Unknown host: zlib.net
ERROR: /root/.cache/bazel/_bazel_root/e50ebc2a7cac8d93968e5988863c67ce/external/com_google_protobuf/BUILD:150:1: @com_google_protobuf//:protobuf depends on @zlib//:zlib in repository @zlib which failed to fetch. no such package '@zlib//': java.io.IOException: Error downloading [https://zlib.net/zlib-1.2.11.tar.gz] to /root/.cache/bazel/_bazel_root/e50ebc2a7cac8d93968e5988863c67ce/external/zlib/zlib-1.2.11.tar.gz: Unknown host: zlib.net
ERROR: Analysis of target '//admin:update' failed; build aborted: no such package '@zlib//': java.io.IOException: Error downloading [https://zlib.net/zlib-1.2.11.tar.gz] to /root/.cache/bazel/_bazel_root/e50ebc2a7cac8d93968e5988863c67ce/external/zlib/zlib-1.2.11.tar.gz: Unknown host: zlib.net/test pull-org-test-all |
justaugustus
force-pushed
the
sig-release
branch
from
782ddae to
8e1f48b
Compare
|
/test pull-org-test-all |
| @@ -1,17 +1,21 @@ | |||
| teams: | |||
| k8s-container-image-promoter-admins: | |||
| description: "admin access to k8s-container-image-promoter" | |||
| description: admin access to k8s-container-image-promoter | |||
There was a problem hiding this comment.
One comment: While it is up to sig-release to administer their repos as they see fit, I think it's an anti-pattern to tie sig chairpersonship to a repos permission set.
Chairs are a process role, as defined in the dig governance docs. There are certain places where it makes sense for the chairs/leads to automatically be in owners files (mainly k/community meta docs, and k/org github meta data -- specifically where being in the owners file is directly tied to administering the sig), but I think in most cases actual access to things should be delegated to subproject owners.
This is similar to how the steering committee no longer gets automatic github owner to everything, rather they delegate that to the subproject that administers it.
To be clear though, this is just my opinion, and is not blocking (strictly speaking)
cc: @kubernetes/sig-release
There was a problem hiding this comment.
@cblecker -- That's fair.
To be more explicit, SIG Release Chairs are subproject owners of the Release Engineering project and should have ownership of all tools/processes which have the potential to affect a Kubernetes release.
I was going to cite some things from our charter, specifically, deviations from SIG governance e.g., SIG Release does not have Technical Leads, as the Chairs are required to be technical, but it seems the charter is due for some updates (which I'll action on this cycle).
p.s. agreed on the Steering point; I did open the issue, after all. 😝
There was a problem hiding this comment.
Ahh okay. I think we then just need to be explicit that Stephen and Caleb are added to this group because they are subproject owners, not because they are chairs. They're two distinct jobs, even though the same person can hold both. Is that right?
There was a problem hiding this comment.
@cblecker -- yep, yep. Updated the PR description and commit comment to reflect.
|
@justaugustus: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-org-test-all |
| - nikhita # ContribEx | ||
| - spiffxp # Testing | ||
| members: | ||
| - abgworrall # GCP | ||
| - alejandrox1 # 1.15 CI Signal | ||
| - adisky # OpenStack |
There was a problem hiding this comment.
Is there any particular reason we are still providing access to old SIG-<cloud-provider> leads now that they've been folded into SIG Cloud Provider?
There was a problem hiding this comment.
@nikhita -- there's still provider code in k/k, so those contributors will likely still need milestone maintainers privs.
| privacy: closed | ||
| sig-release: | ||
| description: SIG Release Members | ||
| maintainers: | ||
| - mrbobbytables | ||
| - nikhita |
There was a problem hiding this comment.
Out of curiosity, how do we decide who gets added to this team? Is it members who have previously participated in some form in the release team? Is this team also pruned periodically/after a release?
There was a problem hiding this comment.
@nikhita -- SIG Release has the concept of membership --> https://github.com/kubernetes/community/blob/master/sig-release/charter.md#sig-membership
tl;dr Chairs, subproject owners, former RT role leads
We don't currently prune anyone; only add, but members can definitely ask to be removed.
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
- Add Release Engineering subproject owners as maintainers for CIP - Promote cpanato to Branch Manager - Add ps882 to Build Admins - Remove inactive Release Manager Associates - Update milestone-maintainers (compared w/ current SIG Chairs/TLs) - Remove ixdy from release-engineering - Remove 1.15 team from release-team - Rotate release-team-leads - Update sig-release GH team Signed-off-by: Stephen Augustus <saugustus@vmware.com>
justaugustus
force-pushed
the
sig-release
branch
from
8e1f48b to
b5a2937
Compare
|
@justaugustus: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@tpepper @calebamiles @cblecker @nikhita -- this is ready for approval. |
|
LGTM But I'd also like SIGs to maybe cross ref this and take ownership/responsibility for updating their owners files. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve Approving for root. Explicit hold so this doesn't merge before @justaugustus is ready for it to. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, cpanato, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
SIG Release ChairsRelease Engineering subproject owners as maintainers for CIPmilestone-maintainers(compared w/ current SIG Chairs/TLs)release-engineeringrelease-teamrelease-team-leadssig-releaseGH teamSigned-off-by: Stephen Augustus saugustus@vmware.com
(This also syncs up
OWNERS_ALIASESw/ k/community)/hold
/sig release
/area release-eng release-team
/assign @tpepper @calebamiles @mrbobbytables @nikhita @cblecker
cc: @kubernetes/release-engineering @kubernetes/release-team @kubernetes/milestone-maintainers