Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarterly SIG Release teams update #1205

Merged
merged 2 commits into from
Sep 24, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion OWNERS_ALIASES
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ aliases:
- shyamjvs
- wojtek-t
sig-scheduling-leads:
- bsalamat
- ahg-g
- k82cn
sig-service-catalog-leads:
- jberkhahn
Expand All @@ -94,6 +94,8 @@ aliases:
- tashimi
- vllry
sig-windows-leads:
- benmoss
- ddebroy
- michmike
- patricklang
wg-apply-leads:
Expand Down
8 changes: 6 additions & 2 deletions config/kubernetes-sigs/sig-release/teams.yaml
Original file line number Diff line number Diff line change
@@ -1,17 +1,21 @@
teams:
k8s-container-image-promoter-admins:
description: "admin access to k8s-container-image-promoter"
description: admin access to k8s-container-image-promoter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment: While it is up to sig-release to administer their repos as they see fit, I think it's an anti-pattern to tie sig chairpersonship to a repos permission set.

Chairs are a process role, as defined in the dig governance docs. There are certain places where it makes sense for the chairs/leads to automatically be in owners files (mainly k/community meta docs, and k/org github meta data -- specifically where being in the owners file is directly tied to administering the sig), but I think in most cases actual access to things should be delegated to subproject owners.

This is similar to how the steering committee no longer gets automatic github owner to everything, rather they delegate that to the subproject that administers it.

To be clear though, this is just my opinion, and is not blocking (strictly speaking)

cc: @kubernetes/sig-release

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cblecker -- That's fair.

To be more explicit, SIG Release Chairs are subproject owners of the Release Engineering project and should have ownership of all tools/processes which have the potential to affect a Kubernetes release.

I was going to cite some things from our charter, specifically, deviations from SIG governance e.g., SIG Release does not have Technical Leads, as the Chairs are required to be technical, but it seems the charter is due for some updates (which I'll action on this cycle).

p.s. agreed on the Steering point; I did open the issue, after all. 😝

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh okay. I think we then just need to be explicit that Stephen and Caleb are added to this group because they are subproject owners, not because they are chairs. They're two distinct jobs, even though the same person can hold both. Is that right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cblecker -- yep, yep. Updated the PR description and commit comment to reflect.

members:
- calebamiles
- dims
- hh
- justaugustus
- listx
- tpepper
privacy: closed
k8s-container-image-promoter-maintainers:
description: "write access to k8s-container-image-promoter"
description: write access to k8s-container-image-promoter
members:
- calebamiles
- dims
- hh
- justaugustus
- listx
- tpepper
privacy: closed
Expand Down
147 changes: 76 additions & 71 deletions config/kubernetes/sig-release/teams.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ teams:
- calebamiles
- justaugustus
- listx
- ps882
- sumitranr
- tpepper
privacy: closed
Expand All @@ -27,103 +28,98 @@ teams:
maintainers:
- cblecker # ContribEx
- fejta # Testing
- idvoretskyi # PM
- mrbobbytables # 1.15 Enhancements Shadow
- mrbobbytables # 1.17 Enhancements Lead
- nikhita # ContribEx
- spiffxp # Testing
members:
- abgworrall # GCP
- alejandrox1 # 1.15 CI Signal
- adisky # OpenStack
Copy link
Member

@nikhita nikhita Sep 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any particular reason we are still providing access to old SIG-<cloud-provider> leads now that they've been folded into SIG Cloud Provider?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhita -- there's still provider code in k/k, so those contributors will likely still need milestone maintainers privs.

- ahg-g # Scheduling
- alejandrox1 # 1.17 RT Lead Shadow
- aleksandra-malinowska # Patch Release Team
- andrewsykim # Cloud Provider
- benmoss # Windows
- bgrant0607 # Architecture
- bradamant3 # Docs
- brancz # Instrumentation
- bsalamat # Scheduling
- bubblemelon # 1.15 Branch Manager
- bubblemelon # Branch Manager
- calebamiles # Release / PM
- carolynvs # Service Catalog
- cantbewong # VMware
- caseydavenport # Network
- castrojo # 1.15 Communications
- chenopis # Docs
- cheftako # Cloud Provider
- childsb # Storage
- claurence # 1.15 Lead
- craiglpeters # 1.15 Enhancements Shadow
- csbell # Multicluster
- chrigl # OpenStack
- cpanato # Branch Manager
- craiglpeters # Azure
- d-nishi # AWS
- danielromlein # UI
- dcbw # Network
- dchen1107 # Node
- deads2k # API Machinery
- derekwaynecarr # Node
- dims # Release
- directxman12 # Autoscaling
- dklyle # OpenStack
- ddebroy # Windows
- deads2k # API Machinery / Auth
- derekwaynecarr # Architecture / Node
- dims # Architecture / Release
- dougm # Patch Release Team
- dstrebel # Azure / 1.15 Bug Triage Shadow
- duglin # Service Catalog
- enj # Auth
- evillgenius75 # 1.16 Enhancements Shadow
- fabriziopandini # Cluster Lifecycle
- feiskyer # Azure
- floreks # UI
- foxish # Big Data
- frapposelli # VMware
- hoegaarden # Patch Release Team
- hogepodge # Cloud Provider / OpenStack
- idealhack # Branch Manager / Patch Release Team
- imkin # 1.15 Test Infra
- jagosan # Cloud Provider
- hpandeycodeit # Usability
- idealhack # Patch Release Team
- janetkuo # Apps
- jberkhahn # Service Catalog
- jberkus # Release
- jdumars # Architecture
- jimangel # 1.15 CI Signal Shadow
- jdumars # Architecture / PM
- jeefy # UI
- jimangel # Docs
- justaugustus # Azure / PM / Release
- justinsb # AWS
- justinsb # AWS / Cluster Lifecycle
- k82cn # Scheduling
- k8s-release-robot # Release
- kacole2 # 1.16 Enhancement Lead
- khenidak # Azure
- kow3ns # Apps
- kris-nova # AWS
- lachie83 # 1.15 Lead Shadow
- lachie83 # PM
- lavalamp # API Machinery
- liggitt # Release
- liggitt # Auth / Release
- liyinan926 # Big Data
- luxas # Cluster Lifecycle
- MAKOSCAFEE # 1.15 Docs
- mariantalla # 1.16 Enhancement Shadow
- maciaszczykm # UI
- mariantalla # 1.17 RT Lead Shadow
- mattfarina # Apps / Architecture
- mborsz # Scalability
- michmike # Windows
- mikedanese # Auth
- mm4tt # Scalability
- mszostok # Service Catalog
- mwielgus # Autoscaling
- neolit123 # Cluster Lifecycle
- nikopen # 1.15 Lead Shadow
- onyiny-ang # 1.15 Release Notes
- parispittman # ContribEx
- patricklang # Windows
- phillels # ContribEx
- piosz # Instrumentation
- pmorie # Multicluster
- prydonius # Apps
- pwittrock # CLI
- quinton-hoole # Multicluster
- rbitia # 1.16 Enhancements Shadow
- rajakavitha1 # Usability
- saad-ali # Storage
- seans3 # CLI
- shyamjvs # Scalability
- simplytunde # 1.16 Docs Lead
- smourapina # 1.15 CI Signal Shadow
- soggiest # 1.15 Bug Triage
- soltysh # CLI
- spzala # IBM Cloud
- stevekuznetsov # Testing
- tallclair # Auth
- tashimi # Usability
- thockin # Network
- timothysc # Cluster Lifecycle / Testing
- tpepper # 1.15 Lead Shadow / Release
- tpepper # Release
- vllry # Usability
- wojtek-t # Scalability
- xmudrii # 1.15 Bug Triage Shadow
- zacharysarah # Docs
privacy: closed
previously:
Expand Down Expand Up @@ -160,20 +156,17 @@ teams:
- alexeldeib # Release Manager Associate
- bubblemelon # Branch Manager
- calebamiles # subproject owner / Build Admin
- chrisz100 # Release Manager Associate
- cpanato # Release Manager Associate
- cpanato # Branch Manager
- dougm # Patch Release Team
- feiskyer # Patch Release Team
- girikuncoro # Release Manager Associate
- hoegaarden # subproject owner / Patch Release Team
- idealhack # Branch Manager / Patch Release Team
- idealhack # Patch Release Team
- imkin # Release Manager Associate
- ixdy # subproject owner
- javier-b-perez # Release Manager Associate
- justaugustus # Release Manager Associate / Build Admin
- k82cn # Release Manager Associate
- justaugustus # subproject owner / Branch Manager / Build Admin
- listx # Build Admin
- mcrute # Release Manager Associate
- ps882 # Build Admin
- pswica # Release Manager Associate
- slicknik # Release Manager Associate
- sumitranr # Build Admin
Expand All @@ -187,10 +180,11 @@ teams:
members:
- aleksandra-malinowska # Patch Release Team
- bubblemelon # Branch Manager
- cpanato # Branch Manager
- dougm # Patch Release Team
- feiskyer # Patch Release Team
- hoegaarden # Patch Release Team
- idealhack # Branch Manager / Patch Release Team
- idealhack # Patch Release Team
- justaugustus # Branch Manager
- k8s-release-robot
- tpepper # Patch Release Team
Expand All @@ -200,42 +194,35 @@ teams:
release-team:
description: Members of the current Release Team and subproject owners.
maintainers:
- mrbobbytables # 1.16 Enhancements Shadow
- mrbobbytables # 1.17 Enhancements Lead
- spiffxp # subproject owner
members:
- aishsundar # subproject owner
- alejandrox1 # 1.16 CI Signal Lead
- alenkacz # 1.15 CI Signal Shadow
- alejandrox1 # 1.17 RT Lead Shadow
- alenkacz # 1.17 CI Signal Lead
- bubblemelon # Branch Manager
- castrojo # 1.15 Communications Lead
- cartyc # 1.17 Release Notes Lead
- claurence # subproject owner
- craiglpeters # 1.15 Enhancements Shadow
- daminisatya # 1.15 Docs Shadow
- dstrebel # 1.15 Bug Triage Shadow
- cpanato # Branch Manager
- daminisatya # 1.17 Docs Lead
- evillgenius75 # 1.16 Enhancements Shadow
- guineveresaenger # 1.16 RT Lead Shadow
- guineveresaenger # 1.17 RT Lead
- idealhack # Branch Manager
- imkin # 1.15 Test Infra Lead
- jberkus # subproject owner
- jeefy # 1.16 RT Lead Shadow
- jimangel # 1.15 CI Signal Shadow
- jeefy # 1.17 RT Lead Shadow
- josiahbjorgaard # 1.17 Bug Triage Lead
- justaugustus # subproject owner
- kacole2 # 1.16 Enhancements Lead
- Katharine # 1.15 Test Infra Shadow
- lachie83 # 1.15 RT Lead Shadow
- MAKOSCAFEE # 1.15 Docs Lead
- mariantalla # 1.16 Enhancements Shadow
- nickchase # 1.15 Release Notes Shadow
- lachie83 # subproject owner
- mariantalla # 1.17 RT Lead Shadow
- nikopen # 1.16 RT Lead Shadow
- onlydole # 1.16 Communications Lead
- onyiny-ang # 1.15 Release Notes Lead
- onyiny-ang # 1.16 Release Notes Shadow
- rawkode # 1.17 Communications Lead
- rbitia # 1.16 Enhancements Shadow
- saschagrunert # 1.16 Release Notes Lead
- simplytunde # 1.16 Docs Lead
- slicknik # 1.15 Branch Manager Shadow
- smourapina # 1.15 CI Signal Shadow
- soggiest # 1.15 Bug Triage Lead
- taragu # 1.15 Test Infra Shadow
- soggiest # 1.16 CI Signal Shadow
- tpepper # subproject owner
- xmudrii # 1.16 Bug Triage Lead
privacy: closed
Expand All @@ -246,32 +233,39 @@ teams:
and can be used as a notification group.
Remove org members who are not current Release Team Leads.
members:
- guineveresaenger # 1.16 RT Lead Shadow
- jeefy # 1.16 RT Lead Shadow
- lachie83 # 1.16 RT Lead
- nikopen # 1.16 RT Lead Shadow
- alejandrox1 # 1.17 RT Lead Shadow
- guineveresaenger # 1.17 RT Lead
- jeefy # 1.17 RT Lead Shadow
- mariantalla # 1.17 RT Lead Shadow
privacy: closed
sig-release:
description: SIG Release Members
maintainers:
- mrbobbytables
- nikhita
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, how do we decide who gets added to this team? Is it members who have previously participated in some form in the release team? Is this team also pruned periodically/after a release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhita -- SIG Release has the concept of membership --> https://github.com/kubernetes/community/blob/master/sig-release/charter.md#sig-membership

tl;dr Chairs, subproject owners, former RT role leads

We don't currently prune anyone; only add, but members can definitely ask to be removed.

- spiffxp
members:
- abgworrall
- AishSundar
- alejandrox1
- aleksandra-malinowska
- alenkacz
- alexeldeib
- amwat
- BenTheElder
- Bradamant3
- bubblemelon
- caesarxuchao
- calebamiles
- cartyc
- castrojo
- chenopis
- chrisz100
- cjwagner
- claurence
- cpanato
- craiglpeters
- daminisatya
- dashpole
- dchen1107
- dims
Expand All @@ -282,29 +276,35 @@ teams:
- evillgenius75
- feiskyer
- foxish
- girikuncoro
- guineveresaenger
- hoegaarden
- idealhack
- imkin
- ixdy
- javier-b-perez
- jberkus
- jdumars
- jeefy
- jimangel
- josiahbjorgaard
- jpbetz
- justaugustus
- k82cn
- kacole2
- Katharine
- kbarnard10
- krzyzacy
- lachie83
- liggitt
- listx
- MaciekPytel
- MAKOSCAFEE
- mariantalla
- marpaia
- marun
- mbohlool
- mcrute
- mistyhacks
- mohammedzee1000
- monopole
Expand All @@ -313,15 +313,20 @@ teams:
- nwoods3
- onlydole
- onyiny-ang
- ps882
- pswica
- pwittrock
- radhikapc
- rawkode
- rbitia
- saad-ali
- saschagrunert
- shyamjvs
- simplytunde
- slicknik
- soggiest
- steveperry-53
- sumitranr
- tfogo
- tpepper
- wojtek-t
Expand Down