Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releng: Update publishing-bot teams to include Release Managers #3127

Merged
merged 4 commits into from
Dec 6, 2021
Merged

releng: Update publishing-bot teams to include Release Managers #3127

merged 4 commits into from
Dec 6, 2021

Conversation

justaugustus
Copy link
Member

Part of kubernetes/sig-release#1772.

  • sig-release: Rename pub-bot team to publishing-bot-admins
  • publishing-bot-admins: Prune inactive members
  • publishing-bot-admins: Add sig-release-admins
  • publishing-bot-maintainers: Create team

/assign @puerco @cpanato @nikhita @dims
/cc @kubernetes/publishing-bot-reviewers
cc: @kubernetes/release-engineering
/hold for reviews from pub-bot maintainers

@justaugustus
sig-release: Rename pub-bot team to publishing-bot-admins
94865d3 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
publishing-bot-admins: Prune inactive members
5a907a4 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
publishing-bot-admins: Add sig-release-admins
f14736a 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
publishing-bot-maintainers: Create team
1f76f2f 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/github-management Issues or PRs related to GitHub Management subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 5, 2021
@justaugustus justaugustus mentioned this pull request Dec 5, 2021
Closed
10 tasks
cpanato
cpanato approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for @nikhita @dims

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2021
@ameukam
Copy link
Member

ameukam commented Dec 6, 2021

/lgtm

xmudrii
xmudrii approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ameukam
Copy link
Member

ameukam commented Dec 6, 2021

/lgtm

@dims
Copy link
Member

dims commented Dec 6, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, justaugustus, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5def2b3 into kubernetes:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@cpanato cpanato cpanato approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees

@dims dims

@ameukam ameukam

@puerco puerco

@cpanato cpanato

@nikhita nikhita

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@justaugustus @ameukam @dims @k8s-ci-robot @saschagrunert @cpanato @xmudrii @puerco @nikhita