Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert image manifest changes #620

Merged
merged 4 commits into from
Sep 5, 2018

Conversation

calebamiles
Copy link
Contributor

Reverting changes made to the release tooling to support image manifests as we were unable to get the
changes working in time for the 1.12.0. We'll try again for 1.12.2 at the earliest.

caleb miles added 4 commits September 4, 2018 20:53
…r-config-json"

This reverts commit 93b1c10, reversing
changes made to e9f40b8.
…ental-support-in-cli"

This reverts commit e9f40b8, reversing
changes made to ff17b75.
This reverts commit 59dc8ed.
@calebamiles calebamiles requested a review from dims September 5, 2018 00:58
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 5, 2018
@dims
Copy link
Member

dims commented Sep 5, 2018

cc @mkumatag - fyi, we could not switch on experimental in the docker CLI. from last attempt it seems like anago or gcbmgr may be overwriting if we set the value in config.json. that's the last theory we had

@tpepper
Copy link
Member

tpepper commented Sep 5, 2018

The way the reverts show in the history (2x merge revert and 2x commit revert, to revert 3x merges and 4x commits) looks odd, but it’s reverting all changes back to 7e27e08.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: calebamiles, tpepper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [calebamiles,tpepper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@calebamiles
Copy link
Contributor Author

Yeah that's the beauty of merge commits, @tpepper 😭

@mkumatag
Copy link
Member

mkumatag commented Sep 5, 2018

I think we need to spend more time on testing.. I don't have a exact environment, I'll spend some time mimicking this env later.

@k8s-ci-robot k8s-ci-robot merged commit 549c1b1 into kubernetes:master Sep 5, 2018
@calebamiles calebamiles deleted the revert-image-manifest branch September 5, 2018 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants