-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert image manifest changes #620
Revert image manifest changes #620
Conversation
cc @mkumatag - fyi, we could not switch on experimental in the docker CLI. from last attempt it seems like anago or gcbmgr may be overwriting if we set the value in config.json. that's the last theory we had |
The way the reverts show in the history (2x merge revert and 2x commit revert, to revert 3x merges and 4x commits) looks odd, but it’s reverting all changes back to 7e27e08. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: calebamiles, tpepper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yeah that's the beauty of merge commits, @tpepper 😭 |
I think we need to spend more time on testing.. I don't have a exact environment, I'll spend some time mimicking this env later. |
Reverting changes made to the release tooling to support image manifests as we were unable to get the
changes working in time for the 1.12.0. We'll try again for 1.12.2 at the earliest.