Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RT OWNERS #364

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Update RT OWNERS #364

merged 1 commit into from
Nov 15, 2018

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Nov 8, 2018

  • Alphabetize top-level OWNERS
  • Add release-team/OWNERS
  • Add reviewers section for releases/release-x.yy/OWNERS

Two notes here:

  • sig-release-leads and release-team-lead-role are top-level reviewers, so they have been removed from the individual release-x.yy/OWNERS
  • Adding a release-team/OWNERS allows for reviews / /lgtms from recent RT members, but note that approval for top-level changes is restricted to SIG Release Chairs (because of the inherent ephemeral nature of the Release Team)

Signed-off-by: Stephen Augustus foo@agst.us

(This is partially in support of the SIG Release Membership concept introduced in the charter PR: #348)

Signed-off-by: Stephen Augustus <foo@agst.us>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 8, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Nov 8, 2018
@justaugustus
Copy link
Member Author

(for /lgtm)
/assign @tpepper @calebamiles @jdumars

@jdumars
Copy link
Member

jdumars commented Nov 15, 2018

/lgtm
/hold
(unhold at your discretion)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 15, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jdumars, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2018
@k8s-ci-robot k8s-ci-robot merged commit 5dfaa92 into kubernetes:master Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants