Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SIG info (contact info / charter) #348

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Oct 24, 2018

A wild SIG charter has appeared...

/assign @calebamiles @jdumars @tpepper
Signed-off-by: Stephen Augustus foo@agst.us

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 24, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Oct 24, 2018
charter.md Outdated Show resolved Hide resolved
charter.md Outdated Show resolved Hide resolved
charter.md Outdated Show resolved Hide resolved
@justaugustus
Copy link
Member Author

justaugustus commented Oct 24, 2018

Announced on k-sig-release, k-sig-release-leads, and steering: https://groups.google.com/d/topic/kubernetes-sig-release/CIe4ekG7GkE/discussion
Maintaining lazy consensus hold until Friday, November 2nd, EOD PT.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2018
@justaugustus
Copy link
Member Author

Adding our Steering liaisons / reviewers.
/assign @timothysc @spiffxp
/committee steering

rel: kubernetes/steering#31

@k8s-ci-robot k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Oct 24, 2018
charter.md Outdated Show resolved Hide resolved
charter.md Outdated Show resolved Hide resolved
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things that should be removed, but I'd also like to see an addition of what where things live that you currently own. e.g. the entire instructions for the release process

charter.md Outdated Show resolved Hide resolved
charter.md Outdated Show resolved Hide resolved
charter.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@justaugustus
Copy link
Member Author

I think I've addressed everyone's comments. Most of it was just tweaking language.

There are some things that should be removed, but I'd also like to see an addition of what where things live that you currently own. e.g. the entire instructions for the release process

@timothysc -- I've removed the subprojects section. k/sig-release is the canonical location for all things SIG Release related, so instructions on the relevant processes can be found here. Processes related to the Release Team, for example, would be found in k/sig-release/release-team.

I would want additional SIG Release subprojects / WGs to follow the same structure:

k/sig-release
   |- release-team
   |- release-engineering
   |- licensing
   |- lts  

If you're specifically referring to build / release processes, instead of putting that information in the charter, I'd want to formally turn up the Release Engineering team and then task them with building out the documentation (as I know precious little about that process and it's also something that would be subject to change).

Does that sound reasonable to you?

Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit then LGTM from me.

charter.md Outdated Show resolved Hide resolved
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2018
@justaugustus
Copy link
Member Author

Removing lazy consensus hold.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2018
@justaugustus
Copy link
Member Author

Thanks everyone who reviewed this!
Ready for a final /approve.

@timothysc
Copy link
Member

@spiffxp for final comments.

charter.md Outdated Show resolved Hide resolved
charter.md Outdated Show resolved Hide resolved
charter.md Outdated Show resolved Hide resolved
charter.md Outdated Show resolved Hide resolved
charter.md Outdated

### Deviations from [sig-governance]

- SIG Release does not have top-level SIG Technical Leads; SIG Release Chairs can serve in both an operational and technical capacity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would caveat this by saying that we don't currently have any technical leads in deference to subproject leads

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent was that we don't require Technical Leads, either now or in the future, as our Chairs are capable of executing technical duties, as well as the fact that we'll have multiple subproject chairs for specific areas. Do you feel that's captured here or disagree with that sentiment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asking the SIG release chair to be "technical" is not inclusionary language. It also implies vague powers for technical arbitration that rightly belongs to sub-projects. Chairs are responsible for the organization, facilitation, and administrivia of the umbrella group. In that regard, SIG Release is not different than any other SIG WRT chairs. I would strike this language.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, realizing now that the phrasing didn't match my intent. So stricken.

charter.md Outdated Show resolved Hide resolved
charter.md Outdated Show resolved Hide resolved
charter.md Outdated Show resolved Hide resolved
charter.md Outdated Show resolved Hide resolved
@justaugustus justaugustus mentioned this pull request Nov 8, 2018
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 8, 2018
@justaugustus
Copy link
Member Author

@calebamiles / @tpepper -- I've addressed your comments. PTAL when you have a chance.
I'm dropping a hold on this again, to ensure we have consensus with the Chairs before merging.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2018
Signed-off-by: Stephen Augustus <foo@agst.us>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 8, 2018
@justaugustus
Copy link
Member Author

Charter has been moved to k/community per Steering request (@timothysc + @spiffxp), so this PR just contains updates to contact info and a link to the charter now.

Ready for a /lgtm.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2018
@justaugustus justaugustus changed the title Add SIG Release charter Update SIG info (contact info / charter) Nov 8, 2018
@jdumars
Copy link
Member

jdumars commented Nov 8, 2018

I'll let @calebamiles clear his change request, and then we can LGTM.

@timothysc
Copy link
Member

I'm fine with any other changes now, it's your wheelhouse.

@timothysc
Copy link
Member

/unassign @timothysc

@calebamiles
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: calebamiles, justaugustus, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [calebamiles,justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 669e029 into kubernetes:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants