-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SIG info (contact info / charter) #348
Conversation
Announced on |
Adding our Steering liaisons / reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some things that should be removed, but I'd also like to see an addition of what where things live that you currently own. e.g. the entire instructions for the release process
I think I've addressed everyone's comments. Most of it was just tweaking language.
@timothysc -- I've removed the subprojects section. I would want additional SIG Release subprojects / WGs to follow the same structure:
If you're specifically referring to build / release processes, instead of putting that information in the charter, I'd want to formally turn up the Release Engineering team and then task them with building out the documentation (as I know precious little about that process and it's also something that would be subject to change). Does that sound reasonable to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit then LGTM from me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Removing lazy consensus hold. |
Thanks everyone who reviewed this! |
@spiffxp for final comments. |
charter.md
Outdated
|
||
### Deviations from [sig-governance] | ||
|
||
- SIG Release does not have top-level SIG Technical Leads; SIG Release Chairs can serve in both an operational and technical capacity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would caveat this by saying that we don't currently have any technical leads in deference to subproject leads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent was that we don't require Technical Leads, either now or in the future, as our Chairs are capable of executing technical duties, as well as the fact that we'll have multiple subproject chairs for specific areas. Do you feel that's captured here or disagree with that sentiment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asking the SIG release chair to be "technical" is not inclusionary language. It also implies vague powers for technical arbitration that rightly belongs to sub-projects. Chairs are responsible for the organization, facilitation, and administrivia of the umbrella group. In that regard, SIG Release is not different than any other SIG WRT chairs. I would strike this language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, realizing now that the phrasing didn't match my intent. So stricken.
@calebamiles / @tpepper -- I've addressed your comments. PTAL when you have a chance. /hold |
Signed-off-by: Stephen Augustus <foo@agst.us>
Charter has been moved to Ready for a |
I'll let @calebamiles clear his change request, and then we can LGTM. |
I'm fine with any other changes now, it's your wheelhouse. |
/unassign @timothysc |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: calebamiles, justaugustus, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A wild SIG charter has appeared...
/assign @calebamiles @jdumars @tpepper
Signed-off-by: Stephen Augustus foo@agst.us