Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SIG Release leadership #2778

Merged
merged 1 commit into from
Nov 3, 2018

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Oct 9, 2018

Chairs:

  • Move Jaice Singer DuMars to Emeritus status
  • Add Stephen Augustus
  • Add Tim Pepper

/assign @calebamiles @jdumars @tpepper
/sig release

Signed-off-by: Stephen Augustus foo@agst.us

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 9, 2018
@calebamiles
Copy link
Contributor

@justaugustus,

IMO this charter should live with the rest of the (non-generated) SIG Release information in the github.com/kubernetes/sig-release namespace like our other documentation. Generally, the charter needs to square the content that already exists in the README. We're also proposing a change of leadership without documenting how these changes should be proposed and are approved

@tpepper
Copy link
Member

tpepper commented Oct 11, 2018

Elaborating a bit on Caleb's comment, this week's SIG Release meeting (see Oct. 9, 2018 recording) started with discussion of this draft.

Regarding location of charter files: other SIGs have theirs in k/community repo, with subdir and file of sig-${NAME}/charter.md. It seems confusing for SIG Release to then put ours in k/sig-release. Are there other sigs which place their charter in a non-k/community repo location? My suggestion would be to reduce the content in k/sig-release/README.md and have it mostly link to the charter in k/community/sig-release/charter.md.

Leadership changes: my reading of the current contents of the directory at https://github.com/kubernetes/community/tree/master/committee-steering/governance including the README.md, sig-governance.md, sig-governance-requirements.md, and the new shorter template (which Stephen has copied as is the guidance) is that the intent is for individual SIG charters to mostly say "we follow the normal documented path, plus the following deviations". In particular https://github.com/kubernetes/community/blob/master/committee-steering/governance/sig-governance.md covers a basic path for continuity across members of defined roles in SIGs. If nothing else is proposed for this SIG, the charter could explicitly state that.

That said, this PR introduces changes to SIG chair membership. That should be a separate PR.

I'll note a few other things in the charter directly, but I don't think this draft charter really needs much. It's very aligned with what has come out of steering in the past months for simplified charter guidelines. If we don't have much deviation, we don't have much that needs to be in the charter. Yes the charter is redundant today with k/sig-release's README, but that's because that README was standing in as a rough charter.

- Ensure there is a [consistent group of community members][1.6-retro] in place to support the release process
- Provide guidance and tooling to facilitate the production of automated releases
- Serve as a tightly integrated partner with other SIGs to empower SIGs to integrate their repositories into the release process
Include a 2-3 sentence summary of what work SIG TODO does. Imagine trying to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 12-14 are a remnant of copying the charter template and should be removed.


### Out of scope

TBD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An initial item here might be "support". While the release team operates the crank that produces new releases, manages patch releases, and ends patch release streams on older releases, the SIG itself is not responsible for end user support or creation of patches for support streams. There are support forums for end users to ask questions and report bugs, subject matter experts in other SIGs triage and address issues and when necessary mark bug fixes for inclusion in a patch release.


## Roles and Organization Management

This sig follows adheres to the Roles and Organization Management outlined in [sig-governance]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove either "follows" or "adheres".

It might be more clear to add something like:

Specifically, the common guidelines (see: [sig-governance.md](https://github.com/kubernetes/community/blob/master/committee-steering/governance/sig-governance.md)) for continuity of membership within roles in the SIG are followed.


### Deviations from [sig-governance]

- SIG Release does not have top-level SIG Technical Leads
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree currently, but can see this changing for a few reasons. First, we don't have any subprojects listed in the charter yet. As patch manager becomes less a role for three individuals, one per each of the prior three releases that are considered supported, and more of a team effort, this patch release team might become a subproject formally. If so that would have subproject chairs, but if not, it probably should have a tech lead. Also presuming a WG LTS is formed, I can see having a SIG Release tech lead associated with that, until such time as it either disbands or returns an implementable LTS KEP to SIG Release, which would then likely become a subproject with chairs.

- KEP *MUST* establish subproject chairs
- [sigs.yaml] *MUST* be updated to include subproject information and [OWNERS] files with subproject chairs
- Where subprojects processes differ from the SIG governance, they must document how
- e.g. if subprojects release separately - they must document how release and planning is performed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a first charter for SIG Release and we're thinking of adding some subprojects, I think it would make sense to explicitly say here that there are currently no formal subprojects of SIG Release, but that {give list} are being considered for proposal as subprojects in the near future. Any of those that don't pass muster for subproject status may also then end up in the Out Of Scope section.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the last year there's been talked about subprojects for the 1.X release teams, driving release engineering process and automation improvements, doing more around source code license and compliance management, improving security and adding provenance / threat modeling, and changing the support stream model (ie: to LTS or to not LTS).

@spiffxp
Copy link
Member

spiffxp commented Oct 11, 2018

/committee steering

@k8s-ci-robot k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Oct 11, 2018
@justaugustus
Copy link
Member Author

(following the thread, btw. I'm just away at a company event at the moment, so I won't be able to address feedback until later.)

@justaugustus justaugustus changed the title [WIP] Add SIG Release Charter Update SIG Release leadership Oct 24, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2018
@justaugustus
Copy link
Member Author

After discussing with @calebamiles offline, I'm moving the charter to k/sig-release, as we already keep all of our other documentation there: kubernetes/sig-release#348

@tpepper -- I've incorporated your feedback on that PR.

Switching this PR into the PR for the leadership changes.

@jdumars
Copy link
Member

jdumars commented Oct 24, 2018

I am sad to be a deletion in the file, but also glad to see the next wave of project leadership emerge.

/lgtm
/meow

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2018
@k8s-ci-robot
Copy link
Contributor

@jdumars: cat image

In response to this:

I am sad to be a deletion in the file, but also glad to see the next wave of project leadership emerge.

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member Author

justaugustus commented Oct 24, 2018

Announced on k-sig-release, k-sig-release-leads, and steering: https://groups.google.com/d/topic/kubernetes-sig-release/CIe4ekG7GkE/discussion
Maintaining lazy consensus hold until Friday, November 2nd, EOD PT.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2018
@timothysc
Copy link
Member

LGTM - But what does this mean you two plan to stay in this roll for some period of time across (N) releases, b/c historically release managers rotate.

sigs.yaml Outdated
@@ -1386,16 +1386,23 @@ sigs:
- https://raw.githubusercontent.com/kubernetes/features/master/OWNERS
- name: Release
dir: sig-release
charter_link:
charter_link: https://git.k8s.io/sig-release/charter.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @timothysc @spiffxp
I don't know if there are specific guidelines for charter location, but CC'ing steering to ensure this is cool with them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The charter typically lives in the community repo next to all the other sig details, not in an external repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of the important documentation for SIG release lives at github.com/kubernetes/sig-release we are unique in that regard but I would strongly like to continue in that direction. I would say that we shouldn't use a vanity URL in the link though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... we provide the field to specify charter_link. I feel that implies that charters don't necessarily need to live in k/community as charter.md. If that's not the case, we should remove that field from the generator.

As Caleb mentioned, k/sig-release is the canonical source for all SIG Release information, so I think having the SIG's defining document adjacent to other SIG Release info is important.
While I can get the need of not wanting break current convention, SIG Release is one of the few (maybe only) SIGs that has their own repo, and it's well-organized. Let me know what you think!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, any reason to not use the vanity URL, @calebamiles?
It's the suggested method (for markdown, at least): https://github.com/kubernetes/community/blob/master/sig-contributor-experience/markdown-link-style-guide.md

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Charters should really be homed in a single location from a discoverability and policy enforcement perspective. If there are bulk edits to how we do charters, the person responsible would have to track across (N). I don't think sig-release is unique from a charter perspective.

Copy link
Member Author

@justaugustus justaugustus Oct 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think SIG Release is unique insofar as where the SIGs documentation is constantly put. That said, I don't have a strong opinion (@calebamiles does, however) on where we land our governing document, outside of saying I hope it would stay close to the day-to-day docs we craft.

If Steering would prefer the charter remain in the community repo, as opposed to in k/sig-release, I'd want that to be explicitly said, as well as having charter_link be removed from the generator template. If we're saying that charters will always be within the SIG dir, named as charter.md, than the additional field has no use outside of allowing confusion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justaugustus The field allowed for transition when some charter docs (before there was formal structure) were in docs and the like. I don't think we need to force a technical limitation on the generator here, when a policy one will do just fine. Setting that value to charter.md like most other sigs have works just fine.

@jberkus
Copy link
Contributor

jberkus commented Oct 24, 2018

@timothysc SIG-Release Lead != Version Release Lead.

That is, the leads for the SIG are different from the leads for each of the releases. The terminology makes it confusing. But the SIG leads are supposed to focus on long-term release needs, instead of the current release.

@justaugustus
Copy link
Member Author

Yep. What Josh said.
The official terminology would be SIG Release Chair (SIG wide) and Kubernetes x.y Release Team Lead (Release Team subproject-scoped).

Signed-off-by: Stephen Augustus <foo@agst.us>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2018
@justaugustus
Copy link
Member Author

Removed the charter link. Needs a re-/lgtm.

@cblecker
Copy link
Member

/lgtm
/approve
/hold

Feel free to remove hold once lazy consensus period expires.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2018
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@justaugustus
Copy link
Member Author

Thanks @timothysc!

@justaugustus
Copy link
Member Author

Removing lazy consensus hold.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit 45e08ba into kubernetes:master Nov 3, 2018
@justaugustus
Copy link
Member Author

Thanks everyone who reviewed this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants