Merge pull request #9066 from Katharine/limit-dom-madness

Avoid highlighting diffs in pathological logs.
kubernetes · Aug 16, 2018 · ea66d20 · ea66d20
2 parents fdea22f + 7536cc2
commit ea66d20
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/triage/render.js b/triage/render.js
@@ -233,6 +233,10 @@ function renderSpans(text, spans) {
   if (!spans) {
     return [text];
   }
+  if (spans.length > 1000) {
+    console.warn(`Not highlighting excessive number of spans to avoid browser hang: ${spans.length}`);
+    return [text];
+  }
   var out = [];
   var c = 0;
   for (var i = 0; i < spans.length; i += 2) {