Avoid highlighting diffs in pathological logs. #9066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extremely long logs with many, many mismatches are going to result in the creation of a ridiculous number of DOM nodes. Browsers generally do not respond well to hundreds of thousands of DOM nodes suddenly appearing, and so hang. Limit the number of mismatch spans to 1,000 (several times the observed number on any reasonable test case) before we just show the unhighlighted log.
k8s-ci-robot
added
area/triage
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, Katharine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Deployed |
This was referenced Aug 29, 2018
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extremely long logs with many, many mismatches are going to result in the creation of a ridiculous number of DOM nodes. Browsers generally do not respond well to hundreds of thousands of DOM nodes suddenly appearing, and so hang for a while:
Limit the number of mismatch spans to 1,000 (several times the observed number on any reasonable test case) before we just show the unhighlighted log.
Fixes #9025, which you can reproduce by viewing this specific failure (warning: clicking this link will hang your browser)
/area triage
/assign @BenTheElder