Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boskos should have an automated push/bump/deploy like Prow #11957

Closed
Katharine opened this issue Mar 26, 2019 · 13 comments
Closed

Boskos should have an automated push/bump/deploy like Prow #11957

Katharine opened this issue Mar 26, 2019 · 13 comments
Assignees
Labels
area/boskos Issues or PRs related to code in /boskos kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/oncall-hotlist Categorizes issue or PR as tracked by test-infra oncall. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@Katharine
Copy link
Member

Doing things manually invites mistakes!

/assign @fejta

@Katharine Katharine added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 26, 2019
@Katharine Katharine added area/boskos Issues or PRs related to code in /boskos priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Mar 26, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 24, 2019
@Katharine
Copy link
Member Author

/remove-lifecycle stale

it automatically pushes and bumps, but still does not automatically deploy.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 25, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jul 25, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevekuznetsov
Copy link
Contributor

/remove-lifecycle rotten
/reopen

We're deploying it automatically on the OpenShift side, so this is definitely possible.

@k8s-ci-robot
Copy link
Contributor

@stevekuznetsov: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/reopen

We're deploying it automatically on the OpenShift side, so this is definitely possible.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Aug 24, 2019
@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 24, 2019
@cjwagner
Copy link
Member

/kind oncall-hotlist

The boskos images are currently running at version v20190621-ff01381 even though there have been many changes since then: https://github.com/kubernetes/test-infra/commits/master/boskos

@michelle192837 (current oncall) Could you please publish and deploy the latest boskos images when you get the chance (or make it automatic)?

@k8s-ci-robot k8s-ci-robot added the kind/oncall-hotlist Categorizes issue or PR as tracked by test-infra oncall. label Nov 21, 2019
@fejta
Copy link
Contributor

fejta commented Nov 21, 2019

This is the latest image:

$ gcloud container images list-tags gcr.io/k8s-testimages/boskos
9abcb3ce0bea  v20190621-ff01381                                         2019-06-21T09:04:24

The prow bump already autobumps this to the latest image whenever it changes.

@fejta
Copy link
Contributor

fejta commented Nov 21, 2019

We also have a job to push images whenever they change:

- name: post-test-infra-push-boskos
cluster: test-infra-trusted
run_if_changed: '^(boskos\/|maintenance\/aws-janitor)'
annotations:
testgrid-dashboards: "sig-testing-images"
testgrid-tab-name: "boskos"
testgrid-alert-email: kubernetes-sig-testing-alerts@googlegroups.com, k8s-infra-oncall@google.com
testgrid-num-failures-to-alert: '1'
description: builds and pushes boskos images
decorate: true
branches:
- master
spec:
containers:
- image: gcr.io/k8s-testimages/bazelbuild:v20190916-ec59af8-0.29.1 # whatever image you use here must have bash 4.4+
command:
- boskos/push.sh
env:
- name: GOOGLE_APPLICATION_CREDENTIALS
value: /creds/service-account.json
volumeMounts:
- name: creds
mountPath: /creds
volumes:
- name: creds
secret:
secretName: pusher-service-account

@cjwagner
Copy link
Member

We also have a job to push images whenever they change

I don't think this part is working right. There have been many changes to boskos since June 21, but that is the most recent image we've published: https://github.com/kubernetes/test-infra/commits/master/boskos

If you look at the post submit job statuses on those commits it does look like the post-test-infra-push-boskos job is running, but the images it says it is publishing are not actually being published. e.g. https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/post-test-infra-push-boskos/1173991256389324801 (should have published tag v20190917-d326d2a31.

@cjwagner
Copy link
Member

Ooooh, looks like we have published boskos images to both gcr.io/k8s-testimages and gcr.io/k8s-prow. Our deployments are all referencing gcr.io/k8s-testimages still, but we only push to gcr.io/k8s-prow now so autobump isn't finding the newer images.

@michelle192837
Copy link
Contributor

I believe this is fixed now, and automatically bumps when we do the Prow bump. (Reopen if I'm wrong :P )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/boskos Issues or PRs related to code in /boskos kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/oncall-hotlist Categorizes issue or PR as tracked by test-infra oncall. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

7 participants