Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a grafana dashboard for boskos resource usage. #15344

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

cjwagner
Copy link
Member

Questions:

  1. The leased and other states were not previously graphed and at a glance they are always 0. Should I remove these from the graphs?
  2. I set the default time range to the past day of results. Is that value useful?
  3. Do we care what order the graphs are in?
  4. Are the colors OK? (I didn't use the automatic colors to ensure that the color schemes are consistent between the graphs.)

Here is what it looks like:
boskos-dashboard

/assign @hongkailiu @stevekuznetsov
/cc @sebastienvas
/area boskos

fixes #15303

@k8s-ci-robot k8s-ci-robot added the area/boskos Issues or PRs related to code in /boskos label Nov 20, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/prow Issues or PRs related to prow area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 20, 2019
aliasColors={'busy': '#0000ff', 'cleaning': '#00eeff', 'dirty': '#ff8000', 'free': '#00ff00', 'leased': '#ee00ff', 'other': '#ff0000'}
)
.addTarget(prometheus.target(
'%s_busy' % resource.metric,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the older metrics -- I would suggest

sum(boskos_resources{type="<my-named-thing>"}) by (state)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have that metric in our data... Sounds like our boskos instance isn't being updated properly? I'll open an issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: #11957

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa. That was added ages ago. I thought boskos was automatically rolled out these days?

@cjwagner
Copy link
Member Author

Boskos is now serving the new metric, the grafana dashboards in this PR have been switched to use that. I also made the graphs stack and fill and tweaked the colors to be more readable. Thanks @michelle192837 for the input!
Screenshot from 2019-11-21 14-08-00

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 09ba478 into kubernetes:master Nov 21, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 21, 2019
@cjwagner cjwagner deleted the boskos-dashboards branch November 21, 2019 22:16
@cjwagner
Copy link
Member Author

This was referenced Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/boskos Issues or PRs related to code in /boskos area/prow/bump Updates to the k8s prow cluster area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outage with Velodrome/boskos logs
5 participants