-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a grafana dashboard for boskos resource usage. #15344
Conversation
aliasColors={'busy': '#0000ff', 'cleaning': '#00eeff', 'dirty': '#ff8000', 'free': '#00ff00', 'leased': '#ee00ff', 'other': '#ff0000'} | ||
) | ||
.addTarget(prometheus.target( | ||
'%s_busy' % resource.metric, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the older metrics -- I would suggest
sum(boskos_resources{type="<my-named-thing>"}) by (state)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have that metric in our data... Sounds like our boskos instance isn't being updated properly? I'll open an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref: #11957
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoa. That was added ages ago. I thought boskos
was automatically rolled out these days?
42ed0ce
to
50ff412
Compare
Boskos is now serving the new metric, the grafana dashboards in this PR have been switched to use that. I also made the graphs stack and fill and tweaked the colors to be more readable. Thanks @michelle192837 for the input! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjwagner, michelle192837 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Questions:
leased
andother
states were not previously graphed and at a glance they are always 0. Should I remove these from the graphs?Here is what it looks like:
/assign @hongkailiu @stevekuznetsov
/cc @sebastienvas
/area boskos
fixes #15303