Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow direct triggering of reruns #13321

Closed
mirandachrist opened this issue Jul 3, 2019 · 6 comments
Closed

Allow direct triggering of reruns #13321

mirandachrist opened this issue Jul 3, 2019 · 6 comments
Labels
area/prow/deck Issues or PRs related to prow's deck component kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone

Comments

@mirandachrist
Copy link
Contributor

mirandachrist commented Jul 3, 2019

We want to modify the rerun button so that in addition to displaying the current popup, it also allows authorized users to directly trigger job reruns. See design doc for more details.

#12827 makes the rerun button directly trigger a rerun when the --rerun-creates-job is set to true in Deck

#13008 sets up GitHub oauth to authenticate the user when the rerun button is clicked, adds "Run" button on the rerun popup that, when clicked by an authenticated user, displays "Nice try! The direct rerun feature hasn't been implemented yet, so that button does nothing."

#13142 adds a whitelist of users who are authorized to run any job but does not hook it up to anything.

#13197 adds checks to determine if the authenticated user is on the whitelist of authorized users.

#13323 adds CSRF protection to Deck. This prevents unauthorized users from rerunning jobs using CSRF attacks (see CSRF documentation).

#13480 adds a field to the job config allowing users to specify who is permitted to rerun the job.

#13564 adds logic to check if a user is specified as permitted for a given job, including GitHub teams logic

#13815 adds the same logic used to determine if a user can rerun tests with /test on presubmits

@mirandachrist mirandachrist added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 3, 2019
@stevekuznetsov stevekuznetsov added the area/prow/deck Issues or PRs related to prow's deck component label Jul 9, 2019
@spiffxp
Copy link
Member

spiffxp commented Jul 23, 2019

/milestone v1.16

@mirandachrist
Copy link
Contributor Author

Desired features I won't have time to implement if anyone wants to pick them up:

  • Add a rerun button on Spyglass
  • Add an option to re-resolve refs when rerunning a job

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 13, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 14, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow/deck Issues or PRs related to prow's deck component kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

5 participants