-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow direct triggering of reruns #13321
Comments
/milestone v1.16 |
Desired features I won't have time to implement if anyone wants to pick them up:
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We want to modify the rerun button so that in addition to displaying the current popup, it also allows authorized users to directly trigger job reruns. See design doc for more details.
#12827 makes the rerun button directly trigger a rerun when the
--rerun-creates-job
is set totrue
in Deck#13008 sets up GitHub oauth to authenticate the user when the rerun button is clicked, adds "Run" button on the rerun popup that, when clicked by an authenticated user, displays "Nice try! The direct rerun feature hasn't been implemented yet, so that button does nothing."
#13142 adds a whitelist of users who are authorized to run any job but does not hook it up to anything.
#13197 adds checks to determine if the authenticated user is on the whitelist of authorized users.
#13323 adds CSRF protection to Deck. This prevents unauthorized users from rerunning jobs using CSRF attacks (see CSRF documentation).
#13480 adds a field to the job config allowing users to specify who is permitted to rerun the job.
#13564 adds logic to check if a user is specified as permitted for a given job, including GitHub teams logic
#13815 adds the same logic used to determine if a user can rerun tests with /test on presubmits
The text was updated successfully, but these errors were encountered: