Add /test logic to rerun button for presubmits #13815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/M
k8s-ci-robot
added
size/L
mirandachrist
force-pushed
the
rerun
branch
2 times, most recently
from
a66ed6b
to
639d603
Compare
|
I changed it so now it skips the /test checks unless the config flag is provided |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 838a8ee5292e9f598b31f8c820d99d41aa8703ae
|
k8s-ci-robot
added
the
approved
cjwagner
reviewed
Aug 8, 2019
k8s-ci-robot
removed
the
lgtm
fejta
approved these changes
Aug 9, 2019
| logrus.WithError(err).Fatal("Error loading Prow plugin config.") | ||
| } | ||
| } else { | ||
| logrus.Warning("No plugins configuration was provided to deck. You must provide one to reuse /test checks for rerun") |
There was a problem hiding this comment.
Maybe change it to info in a follow up
|
|
||
| // If the job is a presubmit and has an associated PR, do the same checks as for /test | ||
| if pj.Spec.Type == prowapi.PresubmitJob && pj.Spec.Refs != nil && len(pj.Spec.Refs.Pulls) > 0 { | ||
| if pluginAgent == nil { |
There was a problem hiding this comment.
you could add && pluginAgent != nil to the above and get the same effect, right?
There was a problem hiding this comment.
Yes... I'll also change this in a followup since I want to get this merged today
There was a problem hiding this comment.
^ Fixes made in #13865
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5f991e7092a08847f097f9b023e5506c148db5e9
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fejta, mirandachrist The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
mirandachrist
added a commit
to mirandachrist/test-infra
that referenced
this pull request
Aug 12, 2019
Closed
mirandachrist
added a commit
to mirandachrist/test-infra
that referenced
this pull request
Aug 12, 2019
Merged
mirandachrist
added a commit
to mirandachrist/test-infra
that referenced
this pull request
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work related to #13321. This replicates the checks we do when determining whether a user can use /test on presubmits.
/assign @cjwagner
/cc @fejta