Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single /override creates in multiple (many) Prowjobs in the system #22690

Closed
petr-muller opened this issue Jun 24, 2021 · 4 comments · Fixed by #24447
Closed

Single /override creates in multiple (many) Prowjobs in the system #22690

petr-muller opened this issue Jun 24, 2021 · 4 comments · Fixed by #24447
Assignees
@jmguzik
Labels
area/prow/hook Issues or PRs related to prow's hook component area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@petr-muller
Copy link
Member

What happened:

Single /override command seem to create multiple (sometimes >10) Prowjobs in the system. This skews metrics.

What you expected to happen:
Create 1 prowjob

How to reproduce it (as minimally and precisely as possible):
/override test. I don't know if this happens everytime, but at least the amount of created prowjobs differs between occurrences.

Please provide links to example occurrences, if any:

openshift/assisted-service#2087 (comment) resulted in:

prowjobs
logs

Anything else we need to know?:
@petr-muller petr-muller added the kind/bug Categorizes issue or PR as related to a bug. label Jun 24, 2021
@BenTheElder BenTheElder added area/prow Issues or PRs related to prow area/prow/hook Issues or PRs related to prow's hook component labels Jun 25, 2021
@spiffxp
Copy link
Member

spiffxp commented Aug 9, 2021

/sig testing

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 9, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 7, 2021
@petr-muller
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 8, 2021
@jmguzik jmguzik mentioned this issue Nov 17, 2021
Closed
jmguzik added a commit to jmguzik/test-infra that referenced this issue Nov 23, 2021
@jmguzik
Fix single override creates many ProwJobs in the system
7a5643d 
This commit addresses the problem described in kubernetes#22690. Override once issued,
can spawn many the almost same prowjobs. The root cause of the problem takes
the origin in the statuses returned by GitHub API. There are multiple statuses
with the same context which reflects the history of the job. One repetition of
context handling for override is enough, rest of the statuses can be ignored.
This commit also adjusts unit tests to the real situation, removing maps as
overlapping statuses are possible.

Signed-off-by: Jakub Guzik <jguzik@redhat.com>
@jmguzik
Copy link
Contributor

jmguzik commented Nov 23, 2021

/assign

@jmguzik jmguzik mentioned this issue Nov 23, 2021
Merged
jmguzik added a commit to jmguzik/test-infra that referenced this issue Nov 24, 2021
@jmguzik
Fix single override creates many ProwJobs in the system
d16d1fb 
This commit addresses the problem described in kubernetes#22690. Override once issued,
can spawn many the almost same prowjobs. The root cause of the problem takes
the origin in the statuses returned by GitHub API. There are multiple statuses
with the same context which reflects the history of the job. One repetition of
context handling for override is enough, rest of the statuses can be ignored.
This commit also adjusts unit tests to the real situation, removing maps as
overlapping statuses are possible.

Signed-off-by: Jakub Guzik <jguzik@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmguzik jmguzik

Labels
area/prow/hook Issues or PRs related to prow's hook component area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix single override creates many ProwJobs in the system jmguzik/test-infra
6 participants
@spiffxp @petr-muller @BenTheElder @k8s-ci-robot @k8s-triage-robot @jmguzik