Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix single override creates many ProwJobs in the system #24447

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Fix single override creates many ProwJobs in the system #24447

merged 1 commit into from
Dec 1, 2021

Conversation

jmguzik
Copy link
Contributor

@jmguzik jmguzik commented Nov 23, 2021

This commit addresses the problem described in #22690. Override once issued,
can spawn many the almost same prowjobs. The root cause of the problem takes
the origin in the statuses returned by GitHub API. There are multiple statuses
with the same context which reflects the history of the job. One repetition of
context handling for override is enough, rest of the statuses can be ignored.
This commit also adjusts unit tests to the real situation, removing maps as
overlapping statuses are possible.

/fixes #22690

Signed-off-by: Jakub Guzik jguzik@redhat.com

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 23, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @jmguzik. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 23, 2021
@jmguzik
Copy link
Contributor Author

jmguzik commented Nov 23, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2021
@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow area/prow/plugins Issues or PRs related to prow's plugins for the hook component sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 23, 2021
@petr-muller
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 23, 2021
@jmguzik
Fix single override creates many ProwJobs in the system
d16d1fb 
This commit addresses the problem described in kubernetes#22690. Override once issued,
can spawn many the almost same prowjobs. The root cause of the problem takes
the origin in the statuses returned by GitHub API. There are multiple statuses
with the same context which reflects the history of the job. One repetition of
context handling for override is enough, rest of the statuses can be ignored.
This commit also adjusts unit tests to the real situation, removing maps as
overlapping statuses are possible.

Signed-off-by: Jakub Guzik <jguzik@redhat.com>
@jmguzik
Copy link
Contributor Author

jmguzik commented Nov 24, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2021
@petr-muller
Copy link
Member

/assign @fejta

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, jmguzik, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit c59b9f8 into kubernetes:master Dec 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Dec 1, 2021
@jmguzik jmguzik mentioned this pull request Mar 17, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta approved these changes

@petr-muller petr-muller petr-muller approved these changes

@matthyx matthyx Awaiting requested review from matthyx

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@petr-muller petr-muller

@fejta fejta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/plugins Issues or PRs related to prow's plugins for the hook component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

Single /override creates in multiple (many) Prowjobs in the system
4 participants
@jmguzik @k8s-ci-robot @petr-muller @fejta