Add a controller which creates a tekton pipeline run from a prow job

[ccojocar]

This controller is able to start a Tekton pipeline using the embedded PipelineRun specification defined in the prow job. The user will have to install beforehand all the resources referenced by this Tekton PipelineRun (such as Pipeline CRD, Task CRDs and PipelineResource CRDs).

Before starting the pipeline, the controller will create dynamically the git PipelineResoruce from prow job git reference and it will add it to the PipelineRun input parameters.

Design Doc

cc @rawlingsj @wbrefvem

[k8s-ci-robot]

Hi @ccojocar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ccojocar]

/assign @fejta

[cjwagner]

/assign
/ok-to-test

[stevekuznetsov]

Are there design documents for this? I would love to have a little more rigor for adding 11k LoC.

[spiffxp]

/hold
I agree, I'd really like to see some docs around this. I appreciate the contribution, but IMO dropping a massive PR with no initial conversation or documentation is not the path to a smooth landing in open source projects

eg:

• https://github.com/kubernetes/test-infra/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+tekton - no issues discussing this beforehand
• https://bit.ly/k8s-sig-testing-notes - no discussion at our recurring meeting

[fejta]

/ok-to-test

[fejta]

Agree that a document outlining what you are planning to do will be helpful.

It is not obvious to most people coming to this PR, for example, that this is largely copy/pasted from the build controller.

[ccojocar]

My understanding was that @rawlingsj had some discussions with @cjwagner and @fejta before initialising this work. Anyhow, I will try to prepare a design document hopefully by the next sig-testing meeting that everyone is on the same page.

[ccojocar]

This is the design proposal which I would like to add it on today's sig-testing meeting agenda.

[ccojocar]

In the design proposal review was decided to split this functionality in two separate controllers. The controller from this PR which starts directly the Tekton pipeline and another dedicated controller for Jenkins X, that will convert the Jenkins X pipeline file into Tektont CRDs and then start the appropriate pipeline. The Jenkins X controller, it will be implemented in a separate PR.

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: e1dfcaf56889c73451367bce56517ca6e848bd82

[ccojocar]

@fejta I addressed this issues. You can cancel the hold if the changes look fine to you. Thanks

[fejta]

This seems more appropriate for the other PR. I'd recommend taking out the commit from here as I don't think it works correctly. But happy to address it in a follow-up

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: a74ff7c390f71900c7e5389faa30c79a099515dd

[fejta]

/hold cancel

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 3416bd2ce169915a9d7dbb550a33eff9740ab636

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, fejta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fejta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment