Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding label for Vietnamese language #14817

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Adding label for Vietnamese language #14817

merged 1 commit into from
Oct 17, 2019

Conversation

truongnh1992
Copy link
Member

Adding a label for the Vietnamese translation of our docs.

Ref: kubernetes/website/#16965

Signed-off-by: Nguyen Hai Truong truongnh@vn.fujitsu.com

@k8s-ci-robot
Copy link
Contributor

Welcome @truongnh1992!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 17, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @truongnh1992. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/label_sync Issues or PRs related to code in /label_sync sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 17, 2019
@truongnh1992
Copy link
Member Author

/assign @spiffxp

@nikhita
Copy link
Member

nikhita commented Oct 17, 2019

/unassign @spiffxp
/assign @zacharysarah

/hold
@zacharysarah just want to double check after the discussion in kubernetes/website#16965 ...can you confirm that it's fine to add a new label for Vietnamese? It looks like we have two volunteers now (@truongnh1992 and @ngtuna).

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2019
@remyleone
Copy link

👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2019
@zacharysarah
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2019
@zacharysarah
Copy link

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2019
@truongnh1992
Copy link
Member Author

/retest

1 similar comment
@truongnh1992
Copy link
Member Author

/retest

@nikhita
Copy link
Member

nikhita commented Oct 17, 2019

@truongnh1992 looks like this needs a run of hack/update-labels.sh :)

@nikhita
Copy link
Member

nikhita commented Oct 17, 2019

/hold cancel
based on kubernetes/org#1315

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2019
Adding a label for the Vietnamese translation of our docs.

Ref: kubernetes/website/#16965

Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>
@truongnh1992
Copy link
Member Author

@truongnh1992 looks like this needs a run of hack/update-labels.sh :)

Thank you @nikhita :-) I've just run hack/update-labels.sh

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, truongnh1992

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit c7892ac into kubernetes:master Oct 17, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 17, 2019
@k8s-ci-robot
Copy link
Contributor

@truongnh1992: Updated the label-config configmap in namespace test-pods using the following files:

  • key labels.yaml using file label_sync/labels.yaml

In response to this:

Adding a label for the Vietnamese translation of our docs.

Ref: kubernetes/website/#16965

Signed-off-by: Nguyen Hai Truong truongnh@vn.fujitsu.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/label_sync Issues or PRs related to code in /label_sync cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants