Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate image-pushing jobs to k8s-infra-prow-build-trusted #17489

Merged
merged 1 commit into from
May 2, 2020
Merged

Migrate image-pushing jobs to k8s-infra-prow-build-trusted #17489

merged 1 commit into from
May 2, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented May 2, 2020

k8s-infra-prow-build-trusted has a gcb-builder serviceaccount that is
capable of building/pushing artifacts to staging and releng projects

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 2, 2020
@k8s-ci-robot k8s-ci-robot requested review from chases2 and cjwagner May 2, 2020 01:58
@spiffxp spiffxp mentioned this pull request May 2, 2020
Merged
@spiffxp
Copy link
Member Author

spiffxp commented May 2, 2020

/cc @BenTheElder

@k8s-ci-robot k8s-ci-robot requested a review from BenTheElder May 2, 2020 02:05
@justaugustus
Copy link
Member

/lgtm
FYI @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2020
BenTheElder
BenTheElder reviewed May 2, 2020
View reviewed changes
config/jobs/image-pushing/README.md
@@ -125,7 +125,7 @@ postsubmits:
kubernetes-sigs/some-repo-name:
# The name should be changed to match the repo name above
- name: post-some-repo-name-push-images
cluster: test-infra-trusted
cluster: k8s-infra-prow-build-trusted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should really be a presubmit check enforcing which jobs can run on this cluster, same as the other trusted cluster
otherwise it's not trusted.

until then we shouldn't put anything important on it.

@BenTheElder
Copy link
Member

/hold
#17489 (comment)

should be pretty easy to modify the check to cover this too

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2020
@BenTheElder
Copy link
Member

#17491

@BenTheElder
Copy link
Member

/hold cancel
check is in, but this PR needs rebase

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 2, 2020
@spiffxp @BenTheElder
Migrate image-pushing jobs to k8s-infra-prow-build-trusted
3986238 
k8s-infra-prow-build-trusted has a gcb-builder serviceaccount that is
capable of building/pushing artifacts to staging and releng projects
@BenTheElder BenTheElder force-pushed the migrate-image-pushing-jobs branch from bd6c154 to 3986238 Compare May 2, 2020 06:56
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 2, 2020
@BenTheElder
Copy link
Member

rebased ✨
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2020
@justaugustus
Copy link
Member

I was just about to ask someone to please update config/jobs/image-pushing/k8s-staging-kubernetes.yaml as well.
Thanks Ben!

@k8s-ci-robot k8s-ci-robot merged commit e0ee931 into kubernetes:master May 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 2, 2020
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key k8s-staging-apiserver-network-proxy.yaml using file config/jobs/image-pushing/k8s-staging-apiserver-network-proxy.yaml
  • key k8s-staging-apisnoop.yaml using file config/jobs/image-pushing/k8s-staging-apisnoop.yaml
  • key k8s-staging-artifact-promoter.yaml using file config/jobs/image-pushing/k8s-staging-artifact-promoter.yaml
  • key k8s-staging-build-image.yaml using file config/jobs/image-pushing/k8s-staging-build-image.yaml
  • key k8s-staging-cluster-api.yaml using file config/jobs/image-pushing/k8s-staging-cluster-api.yaml
  • key k8s-staging-csi.yaml using file config/jobs/image-pushing/k8s-staging-csi.yaml
  • key k8s-staging-descheduler.yaml using file config/jobs/image-pushing/k8s-staging-descheduler.yaml
  • key k8s-staging-dns.yaml using file config/jobs/image-pushing/k8s-staging-dns.yaml
  • key k8s-staging-e2e-test-images.yaml using file config/jobs/image-pushing/k8s-staging-e2e-test-images.yaml
  • key k8s-staging-external-dns.yaml using file config/jobs/image-pushing/k8s-staging-external-dns.yaml
  • key k8s-staging-kind.yaml using file config/jobs/image-pushing/k8s-staging-kind.yaml
  • key k8s-staging-kops.yaml using file config/jobs/image-pushing/k8s-staging-kops.yaml
  • key k8s-staging-kubernetes.yaml using file config/jobs/image-pushing/k8s-staging-kubernetes.yaml
  • key k8s-staging-metrics-server.yaml using file config/jobs/image-pushing/k8s-staging-metrics-server.yaml
  • key k8s-staging-node-problem-detector.yaml using file config/jobs/image-pushing/k8s-staging-node-problem-detector.yaml
  • key k8s-staging-provider-azure.yaml using file config/jobs/image-pushing/k8s-staging-provider-azure.yaml
  • key k8s-staging-releng.yaml using file config/jobs/image-pushing/k8s-staging-releng.yaml
  • key k8s-staging-service-apis.yaml using file config/jobs/image-pushing/k8s-staging-service-apis.yaml

In response to this:

k8s-infra-prow-build-trusted has a gcb-builder serviceaccount that is
capable of building/pushing artifacts to staging and releng projects

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus justaugustus mentioned this pull request May 3, 2020
Merged
@spiffxp spiffxp deleted the migrate-image-pushing-jobs branch May 4, 2020 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@chases2 chases2 Awaiting requested review from chases2

@cjwagner cjwagner Awaiting requested review from cjwagner

Assignees

@justaugustus justaugustus

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@spiffxp @justaugustus @BenTheElder @k8s-ci-robot