Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releng: Fix args for debian-{base,iptables} and pause image builds #17496

Merged
merged 1 commit into from
May 4, 2020

Conversation

justaugustus
Copy link
Member

Needed for the debian-iptables build in kubernetes/kubernetes#90697.

There were some image build failures after we merged #17476, #17485, and kubernetes/kubernetes#90665:

These jobs need to use the root of kubernetes/kubernetes as the build directory (instead of build/<image-name>) because they're dependent on https://github.com/kubernetes/kubernetes/tree/master/third_party/multiarch/qemu-user-static.

So, we end up with a config similar to the e2e-test-image jobs:

args:
# this is the project GCB will run in, which is the same as the GCR
# images are pushed to.
- --project=k8s-staging-e2e-test-images
# This is the same as above, but with -gcb appended.
- --scratch-bucket=gs://k8s-staging-e2e-test-images-gcb
- --env-passthrough=PULL_BASE_REF
- --build-dir=.
- test/images

The pause image build job didn't run because we moved trusted clusters in #17489 and there was a service account mismatch, which is fixed here.

Signed-off-by: Stephen Augustus saugustus@vmware.com

/assign @BenTheElder @dims
cc: @kubernetes/release-engineering
/sig release
/area release-eng

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 3, 2020
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2020
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dims
Copy link
Member

dims commented May 4, 2020

/approve
/lgtm

@BenTheElder
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cpanato, dims, hasheddan, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 609f0d4 into kubernetes:master May 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 4, 2020
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key k8s-staging-build-image.yaml using file config/jobs/image-pushing/k8s-staging-build-image.yaml
  • key k8s-staging-kubernetes.yaml using file config/jobs/image-pushing/k8s-staging-kubernetes.yaml

In response to this:

Needed for the debian-iptables build in kubernetes/kubernetes#90697.

There were some image build failures after we merged #17476, #17485, and kubernetes/kubernetes#90665:

These jobs need to use the root of kubernetes/kubernetes as the build directory (instead of build/<image-name>) because they're dependent on https://github.com/kubernetes/kubernetes/tree/master/third_party/multiarch/qemu-user-static.

So, we end up with a config similar to the e2e-test-image jobs:

args:
# this is the project GCB will run in, which is the same as the GCR
# images are pushed to.
- --project=k8s-staging-e2e-test-images
# This is the same as above, but with -gcb appended.
- --scratch-bucket=gs://k8s-staging-e2e-test-images-gcb
- --env-passthrough=PULL_BASE_REF
- --build-dir=.
- test/images

The pause image build job didn't run because we moved trusted clusters in #17489 and there was a service account mismatch, which is fixed here.

Signed-off-by: Stephen Augustus saugustus@vmware.com

/assign @BenTheElder @dims
cc: @kubernetes/release-engineering
/sig release
/area release-eng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants