-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
releng: Fix args for debian-{base,iptables} and pause image builds #17496
Conversation
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, cpanato, dims, hasheddan, justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@justaugustus: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Needed for the
debian-iptables
build in kubernetes/kubernetes#90697.There were some image build failures after we merged #17476, #17485, and kubernetes/kubernetes#90665:
These jobs need to use the root of kubernetes/kubernetes as the build directory (instead of
build/<image-name>
) because they're dependent on https://github.com/kubernetes/kubernetes/tree/master/third_party/multiarch/qemu-user-static.So, we end up with a config similar to the e2e-test-image jobs:
test-infra/config/jobs/image-pushing/k8s-staging-e2e-test-images.yaml
Lines 27 to 35 in 8fe3dec
The
pause
image build job didn't run because we moved trusted clusters in #17489 and there was a service account mismatch, which is fixed here.Signed-off-by: Stephen Augustus saugustus@vmware.com
/assign @BenTheElder @dims
cc: @kubernetes/release-engineering
/sig release
/area release-eng