Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap periodic-kubernetes-bazel-test-master for canary #18613

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Aug 2, 2020

@k8s-ci-robot
Copy link
Contributor

@ameukam: The label(s) wg/ cannot be applied, because the repository doesn't have them

In response to this:

Migrate:

https://testgrid.k8s.io/sig-release-master-blocking#bazel-build-master
https://testgrid.k8s.io/sig-release-master-blocking#bazel-test-master

Signed-off-by: Arnaud Meukam ameukam@gmail.com

ref: kubernetes/k8s.io#841

/assign @spiffxp @BenTheElder
/wg k8s-infra

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 2, 2020
@k8s-ci-robot k8s-ci-robot requested review from dims and krzyzacy August 2, 2020 21:25
@spiffxp
Copy link
Member

spiffxp commented Aug 3, 2020

/hold
These can't be migrated as-is. See the description of kubernetes/k8s.io#846 for why build can't be migrated, and it's going to require more effort than releng has bandwidth for in 1.19

I'm confirming test can run without RBE via #18607; if that works, then you would do the same for test

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2020
@BenTheElder
Copy link
Member

/hold
double-hold :-)

super appreciate the effort, the issue is that a major side-effect of these jobs is keeping the bazel cache warm, for use in presubmits
that cache is not cross cluster, and most of the presubmit jobs using the cache can't be moved yet.

we should probably coordinate merging this with being ready to move the rest of the bazel using presubmits

@spiffxp
Copy link
Member

spiffxp commented Aug 3, 2020

a major side-effect of these jobs is keeping the bazel cache warm, for use in presubmits

Hmm, TIL. Are there any other jobs that could serve a similar role? Like pull-kubernetes-e2e-gce or something? Or would we want to consider triggering a non-reporting equivalent of this job on k8s-infra-prow-build?

@spiffxp
Copy link
Member

spiffxp commented Aug 4, 2020

(I guess I'm effectively keeping k8s-infra-prow-build's bazel cache warm by having migrated periodic-kubernetes-bazel-test-canary over there)

@BenTheElder
Copy link
Member

BenTheElder commented Aug 4, 2020 via email

@BenTheElder
Copy link
Member

BenTheElder commented Aug 4, 2020 via email

@spiffxp
Copy link
Member

spiffxp commented Aug 4, 2020

Well, at this point then, I'd like to suggest @ameukam change this PR to do the following:

  • rebase to pick up the changes introduced in Alter bazel-test-canary to run on k8s-infa-prow-build #18607
  • leave periodic-kubernetes-bazel-build-master untouched
  • swap the names of the bazel-test jobs such that
    • periodic-kubernetes-bazel-test-canary = the job that runs on k8s-prow-builds, uses RBE, and is on sig-testing-canaries dashboard
    • periodic-kubernetes-bazel-test-master = the job that runs on k8s-infra-prow-build and is release-blocking

This will leave k8s-prow-builds' bazel cache getting the exact same amount of coverage, while moving the release-blocking test job to a dedicated cluster

@spiffxp
Copy link
Member

spiffxp commented Aug 4, 2020

@ameukam if you redo this as I described, that should take care of #18652

@ameukam ameukam force-pushed the migrate-bazel-jobs branch from 147714d to e7c9d5d Compare August 5, 2020 20:48
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2020
@ameukam
Copy link
Member Author

ameukam commented Aug 5, 2020

@spiffxp I updated the PR based on my understanding of what you came up with.

@ameukam ameukam force-pushed the migrate-bazel-jobs branch from e7c9d5d to e8b58e5 Compare August 5, 2020 21:27
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2020
@spiffxp
Copy link
Member

spiffxp commented Aug 5, 2020

/retitle Swap periodic-kubernetes-bazel-test-master for canary

@k8s-ci-robot k8s-ci-robot changed the title Move some periodic bazel jobs to k8s-infra-prow-build Swap periodic-kubernetes-bazel-test-master for canary Aug 5, 2020
@spiffxp
Copy link
Member

spiffxp commented Aug 5, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit eaf9fa8 into kubernetes:master Aug 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 6, 2020
@k8s-ci-robot
Copy link
Contributor

@ameukam: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key bazel-build-test.yaml using file config/jobs/kubernetes/sig-testing/bazel-build-test.yaml

In response to this:

Migrate:

https://testgrid.k8s.io/sig-release-master-blocking#bazel-build-master
https://testgrid.k8s.io/sig-release-master-blocking#bazel-test-master

Signed-off-by: Arnaud Meukam ameukam@gmail.com

ref: kubernetes/k8s.io#841

/assign @spiffxp @BenTheElder
/wg k8s-infra

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants