-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap periodic-kubernetes-bazel-test-master for canary #18613
Conversation
@ameukam: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold I'm confirming test can run without RBE via #18607; if that works, then you would do the same for test |
/hold super appreciate the effort, the issue is that a major side-effect of these jobs is keeping the bazel cache warm, for use in presubmits we should probably coordinate merging this with being ready to move the rest of the bazel using presubmits |
Hmm, TIL. Are there any other jobs that could serve a similar role? Like pull-kubernetes-e2e-gce or something? Or would we want to consider triggering a non-reporting equivalent of this job on k8s-infra-prow-build? |
(I guess I'm effectively keeping k8s-infra-prow-build's bazel cache warm by having migrated periodic-kubernetes-bazel-test-canary over there) |
it's important that it be a frequent post-submit.
the cache is not aware of presubmit vs potsubmit usage, so we want
postsubmit / periodic to be reasonably frequent, so as the cache is not
drowned out by random PR changes.
eviction is based on least recently accessed.
…On Mon, Aug 3, 2020 at 6:07 PM Aaron Crickenberger ***@***.***> wrote:
(I guess I'm effectively keeping k8s-infra-prow-build's bazel cache warm
by having migrated periodic-kubernetes-bazel-test-canary over there)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18613 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHADK65SSKCNTN2AJCHIETR65NMHANCNFSM4PSXZ4GA>
.
|
we might be able to disable writes from presubmit, but that is not
currently in effect today.
On Mon, Aug 3, 2020 at 7:19 PM Benjamin Elder <bentheelder@google.com>
wrote:
… it's important that it be a frequent post-submit.
the cache is not aware of presubmit vs potsubmit usage, so we want
postsubmit / periodic to be reasonably frequent, so as the cache is not
drowned out by random PR changes.
eviction is based on least recently accessed.
On Mon, Aug 3, 2020 at 6:07 PM Aaron Crickenberger <
***@***.***> wrote:
> (I guess I'm effectively keeping k8s-infra-prow-build's bazel cache warm
> by having migrated periodic-kubernetes-bazel-test-canary over there)
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#18613 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAHADK65SSKCNTN2AJCHIETR65NMHANCNFSM4PSXZ4GA>
> .
>
|
Well, at this point then, I'd like to suggest @ameukam change this PR to do the following:
This will leave k8s-prow-builds' bazel cache getting the exact same amount of coverage, while moving the release-blocking test job to a dedicated cluster |
147714d
to
e7c9d5d
Compare
@spiffxp I updated the PR based on my understanding of what you came up with. |
Migrate: https://testgrid.k8s.io/sig-release-master-blocking#bazel-build-master https://testgrid.k8s.io/sig-release-master-blocking#bazel-test-master Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
e7c9d5d
to
e8b58e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle Swap periodic-kubernetes-bazel-test-master for canary |
/hold cancel |
@ameukam: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Migrate:
https://testgrid.k8s.io/sig-release-master-blocking#bazel-build-master
https://testgrid.k8s.io/sig-release-master-blocking#bazel-test-master
Signed-off-by: Arnaud Meukam ameukam@gmail.com
ref: kubernetes/k8s.io#841
/assign @spiffxp @BenTheElder
/wg k8s-infra