Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct intervals for periodic-kubernetes-bazel-test jobs #18998

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 26, 2020

The canary and main jobs were swapped, but their intervals were not.
The main job should be running more frequently than the canary

This addresses #18652 (comment)

Followup to #18613
Part of #18652

The canary and main jobs were swapped, but their intervals were not.
The main job should be running more frequently than the canary
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 26, 2020
@k8s-ci-robot k8s-ci-robot requested review from chases2 and dims August 26, 2020 16:45
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 26, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Aug 26, 2020

FYI @kubernetes/ci-signal
/cc @ameukam @BenTheElder

Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fd124b7 into kubernetes:master Aug 26, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 26, 2020
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key bazel-build-test.yaml using file config/jobs/kubernetes/sig-testing/bazel-build-test.yaml

In response to this:

The canary and main jobs were swapped, but their intervals were not.
The main job should be running more frequently than the canary

This addresses #18652 (comment)

Followup to #18613
Part of #18652

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the enhance-your-calm-canary branch August 26, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants