Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test if 100-node presubmit runs in k8s-infra #19049

Merged
merged 1 commit into from
Aug 30, 2020
Merged

Test if 100-node presubmit runs in k8s-infra #19049

merged 1 commit into from
Aug 30, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 28, 2020

Part of kubernetes/k8s.io#851
Also part of #18550

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 28, 2020
@k8s-ci-robot k8s-ci-robot requested review from mborsz and mm4tt August 28, 2020 23:07
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 28, 2020
@MushuEE
Copy link
Contributor

MushuEE commented Aug 28, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2020
@spiffxp spiffxp force-pushed the canary-for-kubernetes-100-node-presubmit branch from 2dfce75 to f4b7a22 Compare August 28, 2020 23:39
@k8s-ci-robot k8s-ci-robot added area/testgrid and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 28, 2020
@MushuEE
Copy link
Contributor

MushuEE commented Aug 28, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2020
@MushuEE
Copy link
Contributor

MushuEE commented Aug 29, 2020

Also need

- name: pull-kubernetes-e2e-gce-100-performance-canary
  gcs_prefix: kubernetes-jenkins/pr-logs/directory/pull-kubernetes-e2e-gce-100-performance-canary

in https://github.com/kubernetes/test-infra/blob/5d057dba1fd690e64dedd07a058311877b35c6dd/config/testgrids/conformance/conformance-all.yaml

@spiffxp spiffxp force-pushed the canary-for-kubernetes-100-node-presubmit branch from f4b7a22 to 51cf196 Compare August 29, 2020 00:31
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2020
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MushuEE
Copy link
Contributor

MushuEE commented Aug 29, 2020

/lgtm x3

@spiffxp spiffxp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 84020d6 into kubernetes:master Aug 30, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Aug 30, 2020
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key sig-scalability-presubmit-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-presubmit-jobs.yaml

In response to this:

Part of kubernetes/k8s.io#851
Also part of #18550

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the canary-for-kubernetes-100-node-presubmit branch August 30, 2020 00:00
@spiffxp spiffxp mentioned this pull request Aug 30, 2020
Closed
This was referenced Aug 31, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mborsz mborsz Awaiting requested review from mborsz

@mm4tt mm4tt Awaiting requested review from mm4tt

Assignees

@MushuEE MushuEE

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @MushuEE @k8s-ci-robot