Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ci-kubernetes-e2e-gci-gce to latest kubekins #19632

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Update ci-kubernetes-e2e-gci-gce to latest kubekins #19632

merged 1 commit into from
Oct 20, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Oct 20, 2020 •
edited
Loading

This is to verify #19620 doesn't break anything

Next PR will be to use the new --extract-ci-bucket flag

ref: kubernetes/k8s.io#846 (comment)
ref: #19484 (comment)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 20, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 20, 2020
hasheddan
hasheddan approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp spiffxp mentioned this pull request Oct 20, 2020
Closed
@k8s-ci-robot k8s-ci-robot merged commit dfb9473 into kubernetes:master Oct 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 20, 2020
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml

In response to this:

This is to verify #19620 doesn't break anything

Next PR will be to use the new --extract-ci-bucket flag

ref: kubernetes/k8s.io#846 (comment)
ref: #19484 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the canary-kubekins-9838966 branch October 20, 2020 21:11
@spiffxp spiffxp mentioned this pull request Oct 20, 2020
Merged
@spiffxp
Copy link
Member Author

spiffxp commented Oct 20, 2020

https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gci-gce/1318654183234080768 is using the new image and was able to successfully standup a cluster

Opened #19634 for the next change

@spiffxp spiffxp mentioned this pull request Nov 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@cheftako cheftako Awaiting requested review from cheftako

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @hasheddan