Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-blocking jobs must run in dedicated cluster: ci-kubernetes-build-fast #19484

Closed
spiffxp opened this issue Oct 7, 2020 · 11 comments · Fixed by #19660
Closed

release-blocking jobs must run in dedicated cluster: ci-kubernetes-build-fast #19484

spiffxp opened this issue Oct 7, 2020 · 11 comments · Fixed by #19660
Assignees
Labels
area/jobs kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@spiffxp
Copy link
Member

spiffxp commented Oct 7, 2020

What should be cleaned up or changed:

This is part of #18549

To properly monitor the outcome of this, you should be a member of k8s-infra-prow-viewers@kubernetes.io. PR yourself into https://github.com/kubernetes/k8s.io/blob/master/groups/groups.yaml#L603-L628 if you're not a member.

NOTE: I am not tagging this as "help wanted" because it is blocked on kubernetes/k8s.io#846. Here is my guess at how we could do this:

  • create a duplicate job that pushes to the new bucket writable by k8s-infra-prow-build
  • ensure it's building and pushing appropriately
  • update a release-blocking job to pull from the new bucket
  • if no problems, roll out changes progressively
    • a few more jobs in release-blocking
    • all jobs in release-blocking that use this job's results
    • a job that still runs in the "default" cluster
    • all jobs that use this job's results
  • rename jobs / get rid of the job that runs on the "default" cluster

It will be helpful to note the date/time that PR's merge. This will allow you to compare before/after behavior.

Things to watch for the job

Things to watch for the build cluster

Keep this open for at least 24h of weekday PR traffic. If everything continues to look good, then this can be closed.

/wg k8s-infra
/sig testing
/area jobs

@spiffxp spiffxp added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 7, 2020
@k8s-ci-robot k8s-ci-robot added wg/k8s-infra sig/testing Categorizes an issue or PR as relevant to SIG Testing. area/jobs labels Oct 7, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Oct 7, 2020

/sig release
FYI @kubernetes/release-engineering

@spiffxp
Copy link
Member Author

spiffxp commented Oct 19, 2020

#19487 created a canary job

Next steps to take are spelled out in kubernetes/k8s.io#846 (comment)

Is the job working? If so, it's time to switch other jobs to use the new path

@spiffxp
Copy link
Member Author

spiffxp commented Oct 20, 2020

#19620 updated kubetest to add a --extract-ci-bucket flag

#19632 updates a job to use the new kubetest without the flag to verify nothing breaks

Next PR will add --extract-ci-bucket k8s-release-dev to migrate a job to use the results of the canary job added in #19487

@spiffxp
Copy link
Member Author

spiffxp commented Oct 21, 2020

/help

Now that #19634 has confirmed the new bucket works, remaining steps are:

@cpanato
Copy link
Member

cpanato commented Oct 21, 2020

@spiffxp I will update the ci-kubernetes-build-fast job

@justaugustus
Copy link
Member

/reopen

Reopening this to keep an eye on it, given #19841.
/assign @justaugustus @cpanato

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Reopened this issue.

In response to this:

/reopen

Reopening this to keep an eye on it, given #19841.
/assign @justaugustus @cpanato

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp
Copy link
Member Author

spiffxp commented Nov 6, 2020

Opened #19871 to enforce jobs should be using the k8s-release-dev bucket if they're using ci/latest-fast; caught one outlier

I'm ready to call this done unless there are any remaining concerns

@spiffxp
Copy link
Member Author

spiffxp commented Nov 20, 2020

/close
There have been no concerns raised

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closing this issue.

In response to this:

/close
There have been no concerns raised

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jobs kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants