Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/tests/jobs: add check for use of k8s-release-dev bucket #19871

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Nov 6, 2020

enforce that anything extracting from ci/latest-fast should be
using the k8s-release-dev bucket

drop ci/latest-fast from skew job; I would prefer it use latest-fast,
but ci/stable1 hasn't migrated over yet, and extract-ci-bucket applies
to all extracts

This should close out #19484
but I'll do that manually after looking things over

enforce that anything extracting from ci/latest-fast should be
using the k8s-release-dev bucket

drop ci/latest-fast from skew job; I would prefer it use latest-fast,
but ci/stable1 hasn't migrated over yet, and extract-ci-bucket applies
to all extracts
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Nov 6, 2020
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Nov 6, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Nov 6, 2020

FYI @kubernetes/ci-signal

@spiffxp
Copy link
Member Author

spiffxp commented Nov 6, 2020

/cc @cpanato @ameukam

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for that Aaron

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1e298ae into kubernetes:master Nov 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 6, 2020
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-cli-config.yaml using file config/jobs/kubernetes/sig-cli/sig-cli-config.yaml

In response to this:

enforce that anything extracting from ci/latest-fast should be
using the k8s-release-dev bucket

drop ci/latest-fast from skew job; I would prefer it use latest-fast,
but ci/stable1 hasn't migrated over yet, and extract-ci-bucket applies
to all extracts

This should close out #19484
but I'll do that manually after looking things over

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the enforce-k8s-release-dev-bucket-for-latest-fast branch November 20, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants