-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Generate a schema for the ProwJob crd (#19522)" #23547
Conversation
This reverts commit 914737a. Seems like server side apply didn't work: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-test-infra-deploy-prow/1436369391678656512
/cc @alvaroaleman |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, chaodaiG The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
component( | ||
"prowjob", | ||
"customresourcedefinition", | ||
args = ["--server-side=true"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an attempt to pass --server-side=true
to kubectl apply
for the generated prowjob CRD, since it's too large to be applied on client side. I thought this would work as mentioned in #19522 (comment), but somehow it didn't work. The postsubmit job https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-test-infra-deploy-prow/1436369391678656512 failed with:
$ /usr/bin/kubectl --kubeconfig= --cluster=gke_k8s-prow_us-central1-f_prow --context= --user= apply -f -
The CustomResourceDefinition "prowjobs.prow.k8s.io" is invalid:
* metadata.annotations: Too long: must have at most 262144 bytes
* spec.preserveUnknownFields: Invalid value: true: must be false in order to use defaults in the schema
Note that --server-side=true
was not included in the command.
- @fejta here in case you know how to achieve this
This reverts commit 914737a.
Seems like server side apply didn't work:
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-test-infra-deploy-prow/1436369391678656512