Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable image preloading in all scalability tests. #23607

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

mborsz
Copy link
Member

@mborsz mborsz commented Sep 15, 2021

As described in #19710 (comment)

After having few green runs in periodics for each minor, let's move NODE_PRELOAD_IMAGES to preset-e2e-scalability-common and preset-e2e-kubemark-common.

The expected diff is: adding this env to presubmits (which should be safe as we already tested in CI).

/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 15, 2021
@wojtek-t
Copy link
Member

/lgtm
/approve

/hold - let's wait with submitting until Monday

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mborsz
Copy link
Member Author

mborsz commented Sep 20, 2021

/assign @tosi3k

@tosi3k
Copy link
Member

tosi3k commented Sep 20, 2021

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 901c1d7 into kubernetes:master Sep 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 20, 2021
@k8s-ci-robot
Copy link
Contributor

@mborsz: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-scalability-presets.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-presets.yaml

In response to this:

As described in #19710 (comment)

After having few green runs in periodics for each minor, let's move NODE_PRELOAD_IMAGES to preset-e2e-scalability-common and preset-e2e-kubemark-common.

The expected diff is: adding this env to presubmits (which should be safe as we already tested in CI).

/assign @wojtek-t

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants