Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable new log dumping mechanism for all scalability periodic jobs #19710

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Enable new log dumping mechanism for all scalability periodic jobs #19710

merged 3 commits into from
Oct 28, 2020

Conversation

tosi3k
Copy link
Member

@tosi3k tosi3k commented Oct 27, 2020

Follow-up to #19663 which enabled the new log dumping mechanism for scalability master branch periodic jobs. This would additionally turn them on for 1.16-1.19 scalability CI jobs.

The PR adds a preset-e2e-scalability-periodics-master on the occasion that would facilitate gradual rollout of env var-enabled features in the scalability jobs with a following flow:

  • master periodics: add env var to preset-e2e-scalability-periodics-master,
  • all periodics: after some soak time and having green Testgrid move that env var to preset-e2e-scalability-periodics,
  • periodics + presubmits: after some additional soak time and having green Testgrid move that env var to preset-e2e-scalability-common and/or preset-e2e-kubemark-common.

/sig scalability
/assign @jkaniuk @wojtek-t

@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 27, 2020
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 27, 2020
@jkaniuk
Copy link
Contributor

jkaniuk commented Oct 27, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2020
@tosi3k
Copy link
Member Author

tosi3k commented Oct 27, 2020

CCing current scalability oncall for visibility as this could potentially make our CI jobs go kaboom.

/cc @marseel

@k8s-ci-robot
Copy link
Contributor

@tosi3k: GitHub didn't allow me to request PR reviews from the following users: marseel.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

CCing current scalability oncall for visibility as this could potentially make our CI jobs go kaboom.

/cc @marseel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wojtek-t
wojtek-t reviewed Oct 28, 2020
View reviewed changes
config/jobs/kubernetes/sig-release/release-branch-jobs/1.16.yaml
@@ -194,6 +194,7 @@ periodics:
cron: 0 8-20/12 * * *
labels:
preset-e2e-scalability-common: "true"
preset-e2e-scalability-periodics: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly as in other PRs - can we split release branches from the master?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already split (at the PR level), please check individual commits here.

wojtek-t
wojtek-t reviewed Oct 28, 2020
View reviewed changes
config/jobs/kubernetes/sig-scalability/sig-scalability-presets.yaml

- labels:
preset-e2e-scalability-periodics-master: "true"
env:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm - it seems that it has already been enabled before, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean for master branch...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that was this other PR you were mentioning

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#19663

@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tosi3k, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit e5474d1 into kubernetes:master Oct 28, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 28, 2020
@k8s-ci-robot
Copy link
Contributor

@tosi3k: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key 1.16.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.16.yaml
  • key 1.17.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.17.yaml
  • key 1.18.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.18.yaml
  • key 1.19.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.19.yaml
  • key sig-scalability-experimental-periodic-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-experimental-periodic-jobs.yaml
  • key sig-scalability-golang.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-golang.yaml
  • key sig-scalability-periodic-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-periodic-jobs.yaml
  • key sig-scalability-presets.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-presets.yaml
  • key sig-scalability-release-blocking-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-release-blocking-jobs.yaml

In response to this:

Follow-up to #19663 which enabled the new log dumping mechanism for scalability master branch periodic jobs. This would additionally turn them on for 1.16-1.19 scalability CI jobs.

The PR adds a preset-e2e-scalability-periodics-master on the occasion that would facilitate gradual rollout of env var-enabled features in the scalability jobs with a following flow:

  • master periodics: add env var to preset-e2e-scalability-periodics-master,
  • all periodics: after some soak time and having green Testgrid move that env var to preset-e2e-scalability-periodics,
  • periodics + presubmits: after some additional soak time and having green Testgrid move that env var to preset-e2e-scalability-common and/or preset-e2e-kubemark-common.

/sig scalability
/assign @jkaniuk @wojtek-t

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tosi3k tosi3k mentioned this pull request Oct 29, 2020
Merged
@tosi3k tosi3k deleted the scalability-presets2 branch February 9, 2021 21:31
@mborsz mborsz mentioned this pull request Sep 13, 2021
Merged
@mborsz mborsz mentioned this pull request Sep 15, 2021
Merged
This was referenced Nov 9, 2021
Merged
Merged
@mborsz mborsz mentioned this pull request Aug 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@jkaniuk jkaniuk jkaniuk left review comments

@feiskyer feiskyer Awaiting requested review from feiskyer

@mborsz mborsz Awaiting requested review from mborsz

Assignees

@jkaniuk jkaniuk

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
4 participants
@tosi3k @jkaniuk @k8s-ci-robot @wojtek-t