Add liveness and readiness endpoint to prow-controller-manager. #24042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/prow
k8s-ci-robot
added
the
lgtm
fejta
approved these changes
Oct 19, 2021
cjwagner
force-pushed
the
prow-controller-manager-liveness
branch
from
3308529 to
228b066
Compare
k8s-ci-robot
removed
the
lgtm
fejta
approved these changes
Oct 19, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaodaiG, cjwagner, fejta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating
healthstarts the liveness endpoint, callinghealth.ServeReady()adds the handling for the readiness endpoint.Once this is deployed we can configure the liveness/readiness probes in the deployment file.
We may also need to tweak the rolling update strategy settings to ensure we allow 2 pods to exist during the update. It looks like the manager is already configured for leader election though.
/assign @alvaroaleman @chaodaiG