Configure liveness and readiness probes for prow-controller-manager. #24340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/prow/bump
alvaroaleman
approved these changes
Nov 15, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, cjwagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chaodaiG
reviewed
Nov 15, 2021
| @@ -22,6 +22,11 @@ metadata: | |||
| spec: | |||
| # Mutually exclusive with plank. Only one of them may have more than zero replicas. | |||
| replicas: 1 | |||
| strategy: | |||
There was a problem hiding this comment.
would be nice to also add comment here as being done below. However not worth blocking
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #24042
Since the previous PR,
prow-controller-managercan now have a slower startup due to retrying build manager creation. This PR should change the deployment strategy to allow two pods to coexist during deployment and it should make the rolling deployment strategy aware of when the build managers are ready for use so that the old pod is not removed until the new pod is ready.I just ready all the k8s docs I could find on liveness/readiness probes and a couple articles about potential pitfalls. I think this configuration should give us the behavior we want without risk of crashlooping.
/assign @alvaroaleman @chaodaiG
/hold