Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure liveness and readiness probes for prow-controller-manager. #24340

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Configure liveness and readiness probes for prow-controller-manager. #24340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions config/prow/cluster/prow_controller_manager_deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ metadata:
spec:
# Mutually exclusive with plank. Only one of them may have more than zero replicas.
replicas: 1
strategy:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to also add comment here as being done below. However not worth blocking

type: RollingUpdate
rollingUpdate:
maxSurge: 1
maxUnavailable: 1
revisionHistoryLimit: 2
selector:
matchLabels:
Expand Down Expand Up @@ -57,6 +62,18 @@ spec:
- name: job-config
mountPath: /etc/job-config
readOnly: true
livenessProbe: # Pod is killed if this fails 3 times.
httpGet:
path: /healthz
port: 8081
initialDelaySeconds: 10
periodSeconds: 5
readinessProbe: # Pod is not considered ready (for rolling deploy and request routing) if this fails 3 times.
httpGet:
path: /healthz/ready
port: 8081
initialDelaySeconds: 10
periodSeconds: 3
volumes:
- name: kubeconfig
secret:
Expand Down