Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GracefulNodeShutdown is a beta feature now. Temporarily use both tags #24154

Merged
merged 1 commit into from
Oct 28, 2021
Merged

GracefulNodeShutdown is a beta feature now. Temporarily use both tags #24154

merged 1 commit into from
Oct 28, 2021

Conversation

SergeyKanzhelev
Copy link
Member

Replaces this: #22728
Unblocks this: kubernetes/kubernetes#105482

/sig node
/kind cleanup
/cc @bobbypage @wzshiming

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2021
This was referenced Oct 28, 2021
Closed
Merged
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 28, 2021
@matthyx
Copy link
Contributor

matthyx commented Oct 28, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0f07bd2 into kubernetes:master Oct 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 28, 2021
@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml

In response to this:

Replaces this: #22728
Unblocks this: kubernetes/kubernetes#105482

/sig node
/kind cleanup
/cc @bobbypage @wzshiming

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SergeyKanzhelev SergeyKanzhelev deleted the gracefulShutdownIsBetaNow branch October 28, 2021 06:45
bobbypage added a commit to bobbypage/test-infra that referenced this pull request Nov 4, 2021
@bobbypage
Remove graceful node shutdown e2e job
d94cc48 
The graceful shutdown feature is now beta and the test is running under
existing node-kubelet-serial job. As a result, the dedicated graceful
node shutdown e2e job is no longer necessary. Followup to
kubernetes#24154
@bobbypage bobbypage mentioned this pull request Nov 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbypage bobbypage Awaiting requested review from bobbypage

@wzshiming wzshiming Awaiting requested review from wzshiming

Assignees

@matthyx matthyx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Archived in project
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
3 participants
@SergeyKanzhelev @k8s-ci-robot @matthyx