Remove graceful node shutdown e2e job

[bobbypage]

The graceful shutdown feature is now beta and the test is running under
existing node-kubelet-serial job. As a result, the dedicated graceful
node shutdown e2e job is no longer necessary. Followup to
#24154

[bobbypage]

/assign @SergeyKanzhelev

[bobbypage]

/cc @wzshiming

[SergeyKanzhelev]

Do we know how disruptive for the kubelet the dbus notification? Is the expectation that the kubelet must keep working after cancelled shutdown? May it affect tests that run after it? Should we somehow cleanup after the test passed, like maybe restart the kubelet?

[SergeyKanzhelev]

/triage accepted
/priority backlog
/kind cleanup

[bobbypage]

Do we know how disruptive for the kubelet the dbus notification?

The dbus notification will trigger to the kubelet to shutdown all of the pods. However since the the test is running in serial, it should be graceful shutdown test which receives the signal (and only affects that test).

Is the expectation that the kubelet must keep working after cancelled shutdown?

Yes, it is the expectation. After cancelled shutdown we expect kubelet to back to NodeReady and test waits for that condition to be true.

https://github.com/kubernetes/kubernetes/blob/508e67937e3644ae7a844bf572cde5ef29543690/test/e2e_node/node_shutdown_linux_test.go#L173-L176

May it affect tests that run after it? Should we somehow cleanup after the test passed, like maybe restart the kubelet?

I don't expect that it should affect tests running after it assuming that tests passes and the node gets back into ReadyCondition. In fact it's running in serial right now and everything seems to be fine. https://testgrid.k8s.io/sig-node-kubelet#node-kubelet-serial

The one consideration is that if for some reason we sent dbus signal and the node went to not ready and did not recover as expected then kubelet would be left in a strange state. So maybe to be safe, it may make sense to always restart kubelet at the end of the test. Perhaps it makes sense for every serial test to do that so every serial test can start with "fresh" kubelet :)

[SergeyKanzhelev]

we may want to universally restart kubelet after serial test. Let's not block this PR on it.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobbypage, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/jobs/kubernetes/sig-node/OWNERS [SergeyKanzhelev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@bobbypage: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

• key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml

In response to this:

The graceful shutdown feature is now beta and the test is running under
existing node-kubelet-serial job. As a result, the dedicated graceful
node shutdown e2e job is no longer necessary. Followup to
#24154

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.