Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prow config to run Local Volume Provisioner in Windows 2019 #24241

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Prow config to run Local Volume Provisioner in Windows 2019 #24241

merged 1 commit into from
Nov 5, 2021

Conversation

mauriciopoppe
Copy link
Member

/sig-storage
/cc @jingxu97

@k8s-ci-robot k8s-ci-robot requested a review from jingxu97 November 4, 2021 18:20
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 4, 2021
@mauriciopoppe mauriciopoppe force-pushed the lvp-windows-prow-config branch 2 times, most recently from 2f27b54 to bb32371 Compare November 4, 2021 18:24
@mauriciopoppe
Copy link
Member Author

/assign @msau42
This is my first iteration, I couldn't test it with pj-on-kind.sh because of the service account key limitation but hopefully I can get enough logs from the job to debug it later

msau42
msau42 reviewed Nov 4, 2021
View reviewed changes
...bernetes-sigs/sig-storage-local-static-provisioner/sig-storage-local-static-provisioner.yaml
- --test-cmd-args=--node-os-distro=windows
env:
# minimum size that supports Hyper-V
- name: NODE_SIZE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to add local SSDs to the VM?

Copy link
Member Author

@mauriciopoppe mauriciopoppe Nov 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The e2e tests create virtual hard disks (VHDs) so a physical disk is not needed, what I saw from this guide https://cloud.google.com/kubernetes-engine/docs/how-to/persistent-volumes/local-ssd#formatting_local_ssds_for_windows_server_clusters is that even if the VM has local SSDs attached they need to be formatted and mounted to a location using powershell commands (which we can do through SSH).

I could add this as another e2e test where instead of using VHDs the initialization scripts can format and mount the local SSDs instead.

I've added an env var to create local SSDs (from https://github.com/kubernetes/kubernetes/blob/8ce440c45ce4b70a2d770b990cad2862dd4d9288/cluster/gce/config-default.sh?#L42) for the next iteration of the e2e test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm mainly wondering if there would be some difference between VHD and a physical disk, so it would be good to test both. For now, this is fine.

@mauriciopoppe mauriciopoppe force-pushed the lvp-windows-prow-config branch from bb32371 to d4b88b0 Compare November 5, 2021 00:39
@msau42
Copy link
Member

msau42 commented Nov 5, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mauriciopoppe, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit ec34530 into kubernetes:master Nov 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 5, 2021
@k8s-ci-robot
Copy link
Contributor

@mauriciopoppe: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-storage-local-static-provisioner.yaml using file config/jobs/kubernetes-sigs/sig-storage-local-static-provisioner/sig-storage-local-static-provisioner.yaml

In response to this:

/sig-storage
/cc @jingxu97

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mauriciopoppe mauriciopoppe mentioned this pull request Nov 5, 2021
Merged
@mauriciopoppe mauriciopoppe mentioned this pull request Dec 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@jingxu97 jingxu97 jingxu97 left review comments

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
4 participants
@mauriciopoppe @msau42 @k8s-ci-robot @jingxu97