Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prow config to run Local Volume Provisioner in Windows 2019 #24241

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Prow config to run Local Volume Provisioner in Windows 2019 #24241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions ...netes-sigs/sig-storage-local-static-provisioner/sig-storage-local-static-provisioner.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,44 @@ presubmits:
# docker-in-docker needs privileged mode
securityContext:
privileged: true
- name: pull-sig-storage-local-static-provisioner-e2e-windows-2019
always_run: false
decorate: true
path_alias: sigs.k8s.io/sig-storage-local-static-provisioner
labels:
preset-k8s-ssh: "true"
preset-service-account: "true"
preset-common-gce-windows: "true"
preset-e2e-gce-windows: "true"
preset-bazel-scratch-dir: "true"
preset-bazel-remote-cache-enabled: "true"
preset-dind-enabled: "true"
spec:
containers:
- image: gcr.io/k8s-testimages/kubekins-e2e:v20210902-e4567b8-master
command:
- runner.sh
args:
- hack/e2e.sh
- --
- --test-cmd-args=--allowed-not-ready-nodes=10
- --test-cmd-args=--node-os-distro=windows
env:
# minimum size that supports Hyper-V
- name: NODE_SIZE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to add local SSDs to the VM?

Copy link
Member Author

@mauriciopoppe mauriciopoppe Nov 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The e2e tests create virtual hard disks (VHDs) so a physical disk is not needed, what I saw from this guide https://cloud.google.com/kubernetes-engine/docs/how-to/persistent-volumes/local-ssd#formatting_local_ssds_for_windows_server_clusters is that even if the VM has local SSDs attached they need to be formatted and mounted to a location using powershell commands (which we can do through SSH).

I could add this as another e2e test where instead of using VHDs the initialization scripts can format and mount the local SSDs instead.

I've added an env var to create local SSDs (from https://github.com/kubernetes/kubernetes/blob/8ce440c45ce4b70a2d770b990cad2862dd4d9288/cluster/gce/config-default.sh?#L42) for the next iteration of the e2e test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm mainly wondering if there would be some difference between VHD and a physical disk, so it would be good to test both. For now, this is fine.

value: "e2-standard-2"
- name: NODE_LOCAL_SSDS
value: "2"
# added in https://github.com/kubernetes/kubernetes/pull/105999
- name: WINDOWS_ENABLE_HYPERV
value: "true"
# if the value is changed, also change the hack/e2e.sh Windows image to build!
# this is done so that the e2e test runs faster
- name: WINDOWS_NODE_OS_DISTRIBUTION
value: "win2019"
# docker-in-docker needs privileged mode
securityContext:
privileged: true
mauriciopoppe marked this conversation as resolved.
Show resolved Hide resolved

periodics:
- name: ci-sig-storage-local-static-provisioner-master-gce-latest
Expand Down