Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the sig/pm label to the label configuration #8336

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Add the sig/pm label to the label configuration #8336

merged 1 commit into from
Jun 12, 2018

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Jun 12, 2018

So that /sig pm works.

See #8335 (comment) where it didn't work.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 12, 2018
@nikhita
Copy link
Member Author

nikhita commented Jun 12, 2018

I'm not sure if adding the label to label configuration is enough for the command to work. 🤔

@nikhita
Copy link
Member Author

nikhita commented Jun 12, 2018

cc @kubernetes/sig-contributor-experience-pr-reviews since it adds a new label to labels.yaml.

cc @justaugustus @idvoretskyi since it adds the sig/pm label.

@k8s-ci-robot k8s-ci-robot added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Jun 12, 2018
@nikhita nikhita mentioned this pull request Jun 12, 2018
Merged
@justaugustus
Copy link
Member

/cc

@nikhita nikhita mentioned this pull request Jun 12, 2018
Closed
@justaugustus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2018
idvoretskyi
idvoretskyi approved these changes Jun 12, 2018
View reviewed changes
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@justaugustus
Copy link
Member

/assign @cjwagner

cblecker
cblecker reviewed Jun 12, 2018
View reviewed changes
prow/plugins/label/label_test.go Outdated
@@ -416,6 +416,26 @@ func TestLabel(t *testing.T) {
expectedRemovedLabels: []string{},
commenter: orgMember,
},
{
name: "add sig/pm label",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have tests for a sig label. You can remove these tests.

cblecker
cblecker requested changes Jun 12, 2018
View reviewed changes
label_sync/labels.yaml Outdated
@@ -445,6 +445,12 @@ labels:
target: both
prowPlugin: label
addedBy: anyone
- color: d2b48c
description: Categorizes an issue or PR as relevant to sig-product-management.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it sig-product-management, or just officially sig-pm now? @idvoretskyi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on #8336 (comment), can you fix this to just sig-pm, @nikhita?

@idvoretskyi
Copy link
Member

@cblecker sig-pm

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2018
cblecker
cblecker approved these changes Jun 12, 2018
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2018
@nikhita
Copy link
Member Author

nikhita commented Jun 12, 2018

@cblecker had forgotten to update the docs generation before :)

@cblecker
Copy link
Member

/lgtm
💯

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2018
@justaugustus
Copy link
Member

/lgtm

@grodrigues3
Copy link
Contributor

@krzyzacy @cjwagner can we get an approval here?

@cjwagner
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, cjwagner, idvoretskyi, justaugustus, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit f945178 into kubernetes:master Jun 12, 2018
@k8s-ci-robot
Copy link
Contributor

@nikhita: Updated the label-config configmap from file label_sync/labels.yaml

In response to this:

So that /sig pm works.

See #8335 (comment) where it didn't work.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker cblecker approved these changes

@idvoretskyi idvoretskyi idvoretskyi approved these changes

@cjwagner cjwagner Awaiting requested review from cjwagner

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@idvoretskyi idvoretskyi

@justaugustus justaugustus

@cblecker cblecker

@cjwagner cjwagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nikhita @justaugustus @idvoretskyi @cblecker @grodrigues3 @cjwagner @k8s-ci-robot