Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sig/pm label to SIG list #2250

Closed
wants to merge 1 commit into from

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Jun 12, 2018

In the sig list, the current label for sig-product-management is "none". This is:

  1. well, incorrect. :)
  2. renders wrongly generated code in sig-product-management/README.md.

This PR updates the label as sig/pm.

Currently, we don't have sig/pm in the list of labels in the label configuration in test-infra. Also, the bot command /sig pm doesn't work.

See kubernetes/test-infra#8336 which adds the label to the label configuration and allows the bot command to work. I think we should put an explicit hold on this PR until kubernetes/test-infra#8336 is merged.
/hold

/cc cblecker idvoretskyi justaugustus

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/pm labels Jun 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

Assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 12, 2018
@nikhita
Copy link
Member Author

nikhita commented Jun 12, 2018

Oh well, sig/pm was automatically added here. :)

@nikhita
Copy link
Member Author

nikhita commented Jun 12, 2018

Oh well, sig/pm was automatically added here. :)

That's due to https://github.com/kubernetes/community/blob/master/sig-product-management/OWNERS#L5

@justaugustus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2018
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@idvoretskyi
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2018
@idvoretskyi
Copy link
Member

@nikhita can you please update the PR?

It could be broken by #2068

@cblecker
Copy link
Member

This was completely obsoleted by #2068 :)
/close

@nikhita
Copy link
Member Author

nikhita commented Jun 12, 2018

This was completely obsoleted by #2068 :)

oops, should have checked the open PRs first 🤦‍♀️

@nikhita nikhita deleted the add-sig-pm-label branch August 25, 2018 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants