-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sig/pm label to SIG list #2250
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Oh well, |
That's due to https://github.com/kubernetes/community/blob/master/sig-product-management/OWNERS#L5 |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
This was completely obsoleted by #2068 :) |
oops, should have checked the open PRs first 🤦♀️ |
In the sig list, the current label for sig-product-management is "none". This is:
sig-product-management/README.md
.This PR updates the label as
sig/pm
.Currently, we don't have
sig/pm
in the list of labels in the label configuration in test-infra. Also, the bot command/sig pm
doesn't work.See kubernetes/test-infra#8336 which adds the label to the label configuration and allows the bot command to work. I think we should put an explicit hold on this PR until kubernetes/test-infra#8336 is merged.
/hold
/cc cblecker idvoretskyi justaugustus