Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIG-PM charter and description updated #2068

Merged
merged 6 commits into from
Jun 12, 2018
Merged

SIG-PM charter and description updated #2068

merged 6 commits into from
Jun 12, 2018

Conversation

idvoretskyi
Copy link
Member

Based on the recent discussions at SIG-PM.

cc @apsinha @calebamiles @jdumars @dustinkirkland @nwoods3 @kbarnard10

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 24, 2018
@idvoretskyi
Copy link
Member Author

/retest

@timothysc
Copy link
Member

/assign @jbeda

@stp-ip
Copy link
Member

stp-ip commented Apr 27, 2018

/LGTM as it still needs an Approver review.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 28, 2018
@idvoretskyi
sig-list.md updated
bed39ba 
Signed-off-by: Ihor Dvoretskyi <ihor@linux.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2018
@justaugustus
Copy link
Member

/cc

@k8s-ci-robot k8s-ci-robot requested a review from justaugustus June 5, 2018 19:07
@idvoretskyi
sig-list.md updated
443505e 
Signed-off-by: Ihor Dvoretskyi <ihor@linux.com>
@idvoretskyi
Copy link
Member Author

/retest

@calebamiles
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2018
@jdumars
Copy link
Member

jdumars commented Jun 12, 2018

/approve

1 similar comment
@calebamiles
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: calebamiles, jdumars

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: calebamiles, jdumars

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit a17f442 into kubernetes:master Jun 12, 2018
@idvoretskyi idvoretskyi mentioned this pull request Jun 12, 2018
Closed
@jdumars jdumars mentioned this pull request Jun 24, 2018
Closed
@justaugustus justaugustus mentioned this pull request Feb 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebamiles calebamiles Awaiting requested review from calebamiles

@grodrigues3 grodrigues3 Awaiting requested review from grodrigues3

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@jbeda jbeda

@calebamiles calebamiles

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@idvoretskyi @timothysc @stp-ip @justaugustus @calebamiles @jdumars @k8s-ci-robot @jbeda