Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run triage more frequently as a decorated prowjob #9578

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 26, 2018

Now that triage is running and taking much less time than before, let's run the job more frequently.

Let's also try using pod utilities to get logs uploaded to GCS and results to show in testgrid.

/area testgrid
/kind cleanup

ref: #9271

@k8s-ci-robot k8s-ci-robot added area/testgrid kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 26, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2018
command:
- "timeout"
args:
- "-t"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is -t? I don't see this in the manpages

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's apparently because this is busybox for some reason

$ docker run -ti gcr.io/k8s-testimages/triage timeout -h
timeout: unrecognized option: h
BusyBox v1.27.2 (2018-06-06 09:08:44 UTC) multi-call binary.

Usage: timeout [-t SECS] [-s SIG] PROG ARGS

Runs PROG. Sends SIG to it if it is not gone in SECS seconds.
Defaults: SECS: 10, SIG: TERM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh, right. alpine

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2018
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,spiffxp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member Author

spiffxp commented Sep 26, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8c46efd into kubernetes:master Sep 26, 2018
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap using the following files:

  • key test-infra-periodics.yaml using file config/jobs/kubernetes/test-infra/test-infra-periodics.yaml

In response to this:

Now that triage is running and taking much less time than before, let's run the job more frequently.

Let's also try using pod utilities to get logs uploaded to GCS and results to show in testgrid.

/area testgrid
/kind cleanup

ref: #9271

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the decorated-triage-job branch September 26, 2018 01:36
@spiffxp
Copy link
Member Author

spiffxp commented Sep 26, 2018

$ make build push
docker build -t gcr.io/k8s-testimages/triage:v20180925-8c46efd52 .
Sending build context to Docker daemon  822.8kB
Step 1/5 : FROM jamiehewland/alpine-pypy:2
 ---> b3b7aead62b6
Step 2/5 : RUN apk add --no-cache jq curl bash python
 ---> Using cache
 ---> 1ab7fcd4e786
Step 3/5 : RUN curl -o installer https://sdk.cloud.google.com && bash installer --disable-prompts --install-dir=/ && rm installer && ln -s /google-cloud-sdk/bin/* /bin/
 ---> Using cache
 ---> 285428ff8d8b
Step 4/5 : ADD *.py update_summaries.sh /
 ---> Using cache
 ---> d4eda7531389
Step 5/5 : ENTRYPOINT ["timeout", "-t", "10800", "/update_summaries.sh"]
 ---> Running in f71b5c422ae0
Removing intermediate container f71b5c422ae0
 ---> 4e2f47ab0ef2
Successfully built 4e2f47ab0ef2
Successfully tagged gcr.io/k8s-testimages/triage:v20180925-8c46efd52
docker tag gcr.io/k8s-testimages/triage:v20180925-8c46efd52 gcr.io/k8s-testimages/triage:latest
echo Built gcr.io/k8s-testimages/triage:v20180925-8c46efd52 and tagged with gcr.io/k8s-testimages/triage:latest ;
Built gcr.io/k8s-testimages/triage:v20180925-8c46efd52 and tagged with gcr.io/k8s-testimages/triage:latest
docker push gcr.io/k8s-testimages/triage:v20180925-8c46efd52
The push refers to repository [gcr.io/k8s-testimages/triage]
99bda3531228: Layer already exists
afe2de096c9f: Pushed
45bee0f0ed91: Pushed
78a782c6be2a: Layer already exists
fb29674c6e71: Layer already exists
717b092b8c86: Layer already exists
v20180925-8c46efd52: digest: sha256:4cb623bb7eb5f6f0023957eb0dd869721518b6e9b46f931bff05755584cbd211 size: 1584
docker push gcr.io/k8s-testimages/triage:latest
The push refers to repository [gcr.io/k8s-testimages/triage]
99bda3531228: Layer already exists
afe2de096c9f: Layer already exists
45bee0f0ed91: Layer already exists
78a782c6be2a: Layer already exists
fb29674c6e71: Layer already exists
717b092b8c86: Layer already exists
latest: digest: sha256:4cb623bb7eb5f6f0023957eb0dd869721518b6e9b46f931bff05755584cbd211 size: 1584
echo Pushed gcr.io/k8s-testimages/triage:latest and gcr.io/k8s-testimages/triage:v20180925-8c46efd52
Pushed gcr.io/k8s-testimages/triage:latest and gcr.io/k8s-testimages/triage:v20180925-8c46efd52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants