Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run triage more frequently as a decorated prowjob #9578

Merged
merged 1 commit into from
Sep 26, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion config/jobs/kubernetes/test-infra/test-infra-periodics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,21 @@ periodics:
memory: "2Gi"

- name: ci-test-infra-triage
interval: 1h
decorate: true
interval: 20m
spec:
containers:
- image: gcr.io/k8s-testimages/triage:latest
imagePullPolicy: Always
env:
- name: GOOGLE_APPLICATION_CREDENTIALS
value: /etc/service-account/service-account.json
command:
- "timeout"
args:
- "-t"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is -t? I don't see this in the manpages

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's apparently because this is busybox for some reason

$ docker run -ti gcr.io/k8s-testimages/triage timeout -h
timeout: unrecognized option: h
BusyBox v1.27.2 (2018-06-06 09:08:44 UTC) multi-call binary.

Usage: timeout [-t SECS] [-s SIG] PROG ARGS

Runs PROG. Sends SIG to it if it is not gone in SECS seconds.
Defaults: SECS: 10, SIG: TERM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh, right. alpine

- "10800"
- "/update_summaries.sh"
volumeMounts:
- name: service
mountPath: /etc/service-account
Expand Down
2 changes: 1 addition & 1 deletion testgrid/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6262,7 +6262,7 @@ dashboards:
alert_options:
alert_mail_to_addresses: gke-kubernetes-engprod+alerts@google.com
- name: triage
description: College results for triage page
description: Runs BigQuery queries, summarizes results into clusters, and uploads to GCS for go.k8s.io/triage
test_group_name: ci-test-infra-triage
code_search_url_template:
url: https://github.com/kubernetes/test-infra/compare/<start-custom-0>...<end-custom-0>
Expand Down
2 changes: 1 addition & 1 deletion triage/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ RUN curl -o installer https://sdk.cloud.google.com && bash installer --disable-p
ADD *.py update_summaries.sh /

# Point GOOGLE_APPLICATION_CREDENTIALS at a serviceaccount.json with the necessary permissions.
CMD ["timeout", "-t", "10800", "/update_summaries.sh"]
ENTRYPOINT ["timeout", "-t", "10800", "/update_summaries.sh"]