Changing AtoI to uParseInt to handle overflow problems.

[vegemitecheesetoast]

Changing AtoI to uParseInt to handle overflow problems with 16 bit integers. Also removing the check for port range because uParseInt provides us with that now.

[k8s-ci-robot]

Welcome @vegemitecheesetoast!

It looks like this is your first PR to kubernetes/utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[vegemitecheesetoast]

I signed it

[vegemitecheesetoast]

/assign thockin

[thockin]

Something is funky with gorilla - you can just drop those files from this PR.

/lgtm
/approve

[thockin]

Travis is weird, got a 502 pulling a package. I kicked it

[thockin]

/hold for gorilla changes

[vegemitecheesetoast]

I signed it

[vegemitecheesetoast]

I signed it

[bowei]

It might be 0 if you want the system to pick the port for you..

[thockin]

We need to make a call on this as an API - does it allow 0 and expect the caller to special-case disallow 0, or does it disallow 0 and expect the caller to test for 0 itself? Or do we add a flag `allowZero bool` and let callers decide that way? I actually don't hate that.

…

On Wed, Aug 14, 2019 at 12:21 AM Bowei Du ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In net/net.go <#108 (comment)>: > if err != nil { return 0, err } - if !(0 < portInt && portInt <= 65535) { - return 0, fmt.Errorf("%d is not a valid port: must be between 1 and 65535, inclusive", portInt) + if port == 0 { + return 0, errors.New("Port number can not be 0") It might be 0 if you want the system to pick the port for you.. ------------------------------ In go.mod <#108 (comment)>: > @@ -4,6 +4,7 @@ go 1.12 require ( github.com/davecgh/go-spew v1.1.1 + github.com/gorilla/mux v1.6.3-0.20180517173623-c85619274f5d // indirect weird why it's pulling this stuff in, your change doesn't reference this. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#108?email_source=notifications&email_token=ABKWAVEMBXV6FDIOHXKHN5DQEOXADA5CNFSM4ILPIOLKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCBP25PY#pullrequestreview-274706111>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABKWAVCX3YQZQR4HYMTRV5LQEOXADANCNFSM4ILPIOLA> .

[vegemitecheesetoast]

I have two sided thoughts on this one:

We already have this function I found in kubernetes/

// IsValidPortNum tests that the argument is a valid, non-zero port number.
func IsValidPortNum(port int) []string {
	if 1 <= port && port <= 65535 {
		return nil
	}
	return []string{InclusiveRangeError(1, 65535)}
}

This above code tests it's a valid port number. My thought is this - the purpose of this function isn't to test if the port number is valid, it's just to convert the port number into a 16 bit integer from a string. bowei@'s point is that we may want the system to choose for us. Do we have a separate function that makes that choice?

My other thought is that the function is called ParsePort(), so maybe it should check if it's a valid port, else it should be called ParseInt().

The bool is the third option, Not sure how I feel about that.

I'm new to this codebase, so I'm not quite sure what kubernetes style would gravitate towards.

[thockin]

`IsValidPortNum()` is *specifically* for API validation, where (TTBOMK) nobody ever allows 0.

I'm new to this codebase, so I'm not quite sure what kubernetes style

would gravitate towards. k/utils is ostensibly our best supported and most general-purpose APIs. I don't hate the bool flag. My instinct is that most callers DO NOT want to allow 0, so if we make this allow 0, we violate POLS. Maybe we should audit all the call-sites to see how many do or don't allow 0 ?

…

On Thu, Aug 15, 2019 at 2:37 AM Vegemite Cheese Toast < ***@***.***> wrote: I have two sided thoughts on this one: We already have this function I found in kubernetes/ // IsValidPortNum tests that the argument is a valid, non-zero port number. func IsValidPortNum(port int) []string { if 1 <= port && port <= 65535 { return nil } return []string{InclusiveRangeError(1, 65535)} } This above code tests it's a valid port number. My thought is this - the purpose of this function isn't to test if the port number is valid, it's just to convert the port number into a 16 bit integer from a string. bowei@'s point is that we may want the system to choose for us. Do we have a separate function that makes that choice? My other thought is that the function is called ParsePort(), so maybe it should check if it's a valid port, else it should be called ParseInt(). The bool is the third option, Not sure how I feel about that. I'm new to this codebase, so I'm not quite sure what kubernetes style would gravitate towards. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#108?email_source=notifications&email_token=ABKWAVCRDL5P4UEBNK5EHBDQEUPXDA5CNFSM4ILPIOLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4LLMSY#issuecomment-521582155>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABKWAVCVLFCHRGUWSFYRIFLQEUPXDANCNFSM4ILPIOLA> .

[vegemitecheesetoast]

i signed it

[vegemitecheesetoast]

k/utils is ostensibly our best supported and most general-purpose APIs. I
don't hate the bool flag.

If it's general purpose, bool flag it is! Also added tests.

[vegemitecheesetoast]

The travis failure is not your fault.

@munnerz I told you changing klog,V would hurt. @vegemitecheesetoast do you have a newer klog installed?

# k8s.io/utils/trace
trace/trace.go:100:57: invalid operation: stepThreshold == 0 || stepDuration > stepThreshold || klog.V(4) (mismatched types bool and klog.Verbose)
trace/trace.go:112:56: invalid operation: stepThreshold == 0 || stepDuration > stepThreshold || klog.V(4) (mismatched types bool and klog.Verbose)

This is the version I'm using in go.mod in utils: k8s.io/klog v0.3.0

[thockin]

Thanks!

/lgtm
/approve

[thockin]

go.mod calls for 0.3.0 but go's tooling can sub a newer version.

What does go mod why say? or go mod graph ?

Are you building under a GOPATH or not?

[thockin]

oh, I guess it's not you, it's travis :)

[thockin]

#111 should fix travis

[thockin]

You might have to rebase.

git fetch upstream
git rebase upstream/master
git push -f

[thockin]

oh Travis.

You need to gofmt the file. Most of us end up doing that automatically on save (e.g. https://github.com/thockin/dotfiles/blob/master/vimrc)

[thockin]

Something like

gofmt -s -w net/*.go
git commit -a --amend
git push -f

[vegemitecheesetoast]

OK, I ran the gofmt and did a git diff and saw that it made some fixes. Hope this is ok!

[dims]

@vegemitecheesetoast please see the next problem in the travis CI job results

net/net.go:146:13: result of errors.New call not used
Makefile:29: recipe for target 'vet' failed

[vegemitecheesetoast]

@dims
Sorry it's been so long! since last reply back from me.
net/net.go:146:13: result of errors.New call not used - fixed - sorry don't know what happened there!
Makefile:29: recipe for target 'vet' failed - I'm going to rebase and see if this fixes, because I didn't touch this, so hoping it solves itself :|

[vegemitecheesetoast]

Apparently this travis build now passes. Please let me know if there is anything else I can do, otherwise, do I just wait to get this merged?

[dims]

/lgtm
/approve

Thanks for your efforts @vegemitecheesetoast !

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, thockin, vegemitecheesetoast

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dims,thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment