Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ja: Make docs/setup/learning-environment/minikube.md follow v1.17 of the original text #21852

Closed
kakts opened this issue Jun 17, 2020 · 7 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. language/ja Issues or PRs related to Japanese language

Comments

@kakts
Copy link
Member

kakts commented Jun 17, 2020

This is a Feature Request

What would you like to be added

Update content/ja/docs/setup/learning-environment/minikube.md to follow v1.17 of the original (English) text.

Why is this needed
content/ja/docs/setup/learning-environment/minikube.md is outdated

Comments

/language ja
/good-first-issue

File to update
https://github.com/kubernetes/website/blob/dev-1.17-ja.3/content/ja/docs/setup/learning-environment/minikube.md

Original
https://github.com/kubernetes/website/blob/release-1.17/content/en/docs/setup/learning-environment/minikube.md

diff
https://gist.github.com/kakts/c0bf21501471718b11d0f2ae6b0f0f56

Note
Currently, we use dev-1.17-ja.3 branch. Please open a PR targeting the branch.

@k8s-ci-robot
Copy link
Contributor

@kakts:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

This is a Feature Request

What would you like to be added

Update content/ja/docs/setup/learning-environment/minikube.md to follow v1.17 of the original (English) text.

Why is this needed
content/ja/docs/setup/learning-environment/minikube.md is outdated

Comments

/language ja
/good-first-issue

File to update
https://github.com/kubernetes/website/blob/dev-1.17-ja.3/content/ja/docs/setup/learning-environment/minikube.md

Original
https://github.com/kubernetes/website/blob/release-1.17/content/en/docs/setup/learning-environment/minikube.md

diff
https://gist.github.com/kakts/c0bf21501471718b11d0f2ae6b0f0f56

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 17, 2020
@inductor
Copy link
Member

@kakts

お願いが2つあります

  1. Captureとcontent_templateの差分は取り除いてください
  2. diffのハイライトをGistに入れてください

@kakts
Copy link
Member Author

kakts commented Jun 22, 2020

承知しました

@kakts
Copy link
Member Author

kakts commented Jun 22, 2020

@inductor ありがとうございます。こちら修正しました

@hikkie3110
Copy link
Contributor

/assign

@inductor
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@inductor: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. language/ja Issues or PRs related to Japanese language
Projects
None yet
Development

No branches or pull requests

4 participants