Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ha-master-gce.png with SVG or something else #28654

Closed
jihoon-seo opened this issue Jun 27, 2021 · 4 comments · Fixed by #28720
Closed

Replace ha-master-gce.png with SVG or something else #28654

jihoon-seo opened this issue Jun 27, 2021 · 4 comments · Fixed by #28720
Assignees
@anubha-v-ardhan
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@jihoon-seo
Copy link
Member

This is a Bug Report

Problem:
The image ha-master-gce.png in "Set up a High-Availability Control Plane" page
is in PNG format,
which makes it hard for contributors to edit its content.

Proposed Solution:
Replace ha-master-gce.png with SVG or something else (e.g. Google Drawings object, etc.)
(Example of Google Drawings object:
https://docs.google.com/drawings/d/1muJ7Oxuj_7Gtv7HV9-2zJbOnkQJnjxq-v1ym_kZfB-4/edit?usp=sharing )

Page to Update:

/language en
@jihoon-seo jihoon-seo added the kind/bug Categorizes issue or PR as related to a bug. label Jun 27, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 27, 2021
@jihoon-seo jihoon-seo mentioned this issue Jun 27, 2021
Closed
@sftim
Copy link
Contributor

sftim commented Jun 28, 2021

/triage accepted

We'd prefer SVG images, ideally with the text converted to shapes. It's OK to save an editable version somewhere else - SVG lets you add a comment about where to find the editable version.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 28, 2021
@anubha-v-ardhan
Copy link
Member

I would like to work on this

@anubha-v-ardhan
Copy link
Member

/assign

anubha-v-ardhan pushed a commit to anubha-v-ardhan/website that referenced this issue Jun 30, 2021
issue kubernetes#28654
48a4996
This was referenced Jun 30, 2021
Closed
Closed
anubha-v-ardhan added a commit to anubha-v-ardhan/website that referenced this issue Jun 30, 2021
@anubha-v-ardhan
fixed kubernetes#28654
1110e56
anubha-v-ardhan added a commit to anubha-v-ardhan/website that referenced this issue Jun 30, 2021
@anubha-v-ardhan
fixed kubernetes#28654
6c007de
This was referenced Jun 30, 2021
Closed
Merged
@anubha-v-ardhan
Copy link
Member

anubha-v-ardhan commented Jun 30, 2021 •
edited
Loading

fixing issue in #28720
Sorry for so many closed PRs, I'm newbie and got a little confused : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anubha-v-ardhan anubha-v-ardhan

Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
4 participants
@k8s-ci-robot @sftim @jihoon-seo @anubha-v-ardhan