Replace ha-master-gce.png with SVG

[anubha-v-ardhan]

fixes #28654

[netlify]

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: c9568cb

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/613adbb1dfdb5a0008f0074e

😎 Browse the preview: https://deploy-preview-28720--kubernetes-io-main-staging.netlify.app

[sftim]

Whilst this might meet a narrow definition of issue #28654, what we actually want is to have the diagram in vector format.

This PR as it stands wraps a PNG image in an SVG container, which doesn't count as replacement. There is still a PNG image there.

Also:
We should leave the old PNG image around until the last localization that uses it has migrated.
I would move the SVG into the localized content folders to emphasize that we want localizations to pick it up.

nit: can we rename static/images/docs/ha-master-gce.svg to not use the term “master”

[anubha-v-ardhan]

Thanks for the review @sftim. I'll try to implement the changes.
Can you tell how to convert PNG to SVG the correct way.

[tengqm]

@anubha-v-ardhan There is not such a converter. We have to recreate the image using SVG editor and then replace the PNG with the SVG file.

[anubha-v-ardhan]

@tengqm Thanks I'll do the needful

[jihoon-seo]

I created a new SVG file.

• Google Drawing: https://docs.google.com/drawings/d/1P1YQry4VYAGTx7UwOT4mDajtIByPew54VtkkZASmDdo/edit?usp=sharing
• SVG file: https://drive.google.com/file/d/1X_jUV_Q9vNB83LHKPzvnfOn4ZFcFQhWZ/view?usp=sharing

@anubha-v-ardhan @sftim @tengqm PTAL!

[anubha-v-ardhan]

Thanks @jihoon-seo I'm updating the PR

[anubha-v-ardhan]

@sftim Please check if this is okay now. I have kept the png file back and added the svg file provided by @jihoon-seo above

[jihoon-seo]

I suggest another change.

In docs/tasks/administer-cluster/highly-available-control-plane.md,

-![ha-master-gce](/images/docs/ha-master-gce.png)
+![ha-control-plane](/images/docs/ha-control-plane.svg)

/cc @jihoon-seo
/language en

[anubha-v-ardhan]

Done @jihoon-seo. Thanks

Feedback was incorporated

[sftim]

Preview

[jihoon-seo]

Screenshot of preview:

[jihoon-seo]

How about adding some lines like these?

<!-- if localizing, copy the Google Drawing, update the text, save as SVG, and embed -->
<!-- Google Drawing: https://docs.google.com/drawings/d/1P1YQry4VYAGTx7UwOT4mDajtIByPew54VtkkZASmDdo/edit?usp=sharing -->

[sftim]

Which Google identity owns that drawing? Can we make sure it's some CNCF thing?

[anubha-v-ardhan]

Done @jihoon-seo

[jihoon-seo]

Currently, the owner of that Google Drawing is me (my Google accout), but anyone can make a copy to his/her Google account.

Can we make sure it's some CNCF thing?

@sftim Please let us know how we can achieve this!
(I guess that someone with appropriate permission to CNCF storage or something can do this, is this right?)

[anubha-v-ardhan]

@sftim @jihoon-seo Do we have any updates. What should I do next?

[sftim]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: d8738ca687a1b24e2467ef0a8290b79aa980c659

[sftim]

@anubha-v-ardhan if you view https://deploy-preview-28720--kubernetes-io-main-staging.netlify.app/docs/tasks/administer-cluster/highly-available-control-plane/ (or preview locally) you'll see that the image is not rendering OK. Would you be able to fix that?

[anubha-v-ardhan]

Sorry, my bad. It should work now.

[jihoon-seo]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: fd5105144ecf5e6db459b884d3d7453a9e218cad

[sftim]

Great result
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• content/en/OWNERS [sftim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment