Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate PR check for Front matter precedent #732

Closed
pwittrock opened this issue Jun 27, 2016 · 4 comments
Closed

Automate PR check for Front matter precedent #732

pwittrock opened this issue Jun 27, 2016 · 4 comments

Comments

@pwittrock
Copy link
Member

We need a script that checks for the following on all open PRs and prevents submission until these tests come back clean:

Front matter precedent

All .md pages must start with the following two lines:


---

---

Between these two lines, we can put front-matter YAML if we ever need to, though they are empty now. More importantly, Jekyll will not process Markdown/Liquid for .md files that do not start with a front-matter section.
@pwittrock pwittrock changed the title Automate PR check for Orphaned .md files Automate PR check for Front matter precedent Jun 27, 2016
@johndmulhausen johndmulhausen mentioned this issue Jun 27, 2016
Closed
9 tasks
@artasparks
Copy link
Contributor

What can go in the front matter precedent? Anything?

@artasparks artasparks self-assigned this Jul 18, 2016
@bgrant0607 bgrant0607 mentioned this issue Jul 21, 2016
Closed
@jaredbhatti
Copy link
Contributor

@Kashomon : Are you still working on this?
@devin-donnelly : Is this being handled by existing Travis checks? Also, is what's required in the front matter documented in our templates?

@artasparks
Copy link
Contributor

Nope, sorry. Removing self.

@artasparks artasparks removed their assignment Jan 11, 2017
@steveperry-53 steveperry-53 mentioned this issue Oct 5, 2017
Closed
@steveperry-53
Copy link
Contributor

Travis requires the page to have a title. And the title goes in the front matter. So a page with no front matter fails the Travis CI check.

mikutas pushed a commit to mikutas/k8s-website that referenced this issue Feb 24, 2021
@Pothulapati @cpretzer
update install commands to be Hem v3 (kubernetes#732)
1ca1d4e 
* update install commands to be v3

Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>

* Added man7.org to list of URLs to ignore for htmltest and use https URLs for man7.org to avoid mixed content errors

Signed-off-by: Charles Pretzer <charles@buoyant.io>

Co-authored-by: Charles Pretzer <charles@buoyant.io>
Okabe-Junya pushed a commit to Okabe-Junya/website that referenced this issue Dec 4, 2023
@iamNoah1 @gdenn
@jihoon-seo @christianhuening @ohdle @mkorbi @DaveVentura @DavidWagnerDO @bcubk
Merge dev-de into main (for the first German localization live versio…
420ef5b 
…n) (kubernetes#1463)

* Settings and initial contents for German localization (kubernetes#347)

* first shot

* WIP german contribution index file

* finalized contribution index, add de.toml

* add contentDir to de config section in config.toml

* change request from catherine

* finalizing style guide

* change request from David and Catherine

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* [de] Fix typo in _index.md

* first shot

* change requests

* [de] Add localization cloud computing (kubernetes#711)

* [de] Add localization cloud computing

* [de] Add missing title meta inf

* [de] Adjust wording in cloud computing

* [de] Adjust wording cloud computing

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

* update terms to completed (kubernetes#725)

* update terms to completed

* Update content/de/agile_software_development.md

Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>

* Update cloud_computing.md

Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>

* localize feedback section

* [de] Fix template title for agile software dev (kubernetes#731)

* Add german translation for API Gateway (kubernetes#732)

* Add german translation for API Gateway

Add german translation for API Gateway. Solves kubernetes#507

* Update api_gateway.md

fixed all found typos by

* Update api_gateway.md

small wording adjustment, changes state

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

* [de] Add localization for "abstraction"

* [de] Remove whitespaces

* [de] Remove redundant information

* [de] Rephrase sentence

* [de] Rephrase sentence

* [de] Remove white spaces

* [de] Add localization cloud native tech

* Incorporate suggested change

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

* Incorporate suggested change

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

* Incorporate suggested change

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

* Incorporate suggested change to title

* Update cloud_native_tech.md

* rename files, add semantic line breaks, empty lines (kubernetes#974)

* rename files, add semantic line breaks, empty lines

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* [DE] Take Over Cloud Native Security localization (kubernetes#990)

* add cloud native sec

Signed-off-by: Max Körbächer <m.koerbaecher@reply.de>
Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* edits, semantic line breaks

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* change requests from Jihoon

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* change requests from david

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* change requests from david

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* Update content/de/cloud-native-security.md

Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

* Update content/de/cloud-native-security.md

Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

Co-authored-by: Max Körbächer <m.koerbaecher@reply.de>
Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

* german localize cloud native apps (kubernetes#1085)

* add german localisation for cloud native apps

* add .md

* Apply suggestions from code review

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

* apply change requests - remove redundancy

* Update content/de/cloud-native-apps.md

Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

* Update content/de/cloud-native-apps.md

Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Co-authored-by: David Wagner <daw@dataone.de>
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

* [DE] Add german definition for canary deployment (kubernetes#1247)

* [de] Add german definition for canary deployment

Signed-off-by: Baris Cubukcuoglu <cubukcuoglu.baris@gmail.com>
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

* Update content/de/canary_deployment.md

Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

* Update content/de/canary_deployment.md

Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>

* Update content/de/canary_deployment.md

Signed-off-by: Noah Ispas <Noahispas@gmail.com>

Signed-off-by: Baris Cubukcuoglu <cubukcuoglu.baris@gmail.com>
Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

* german autoscaling localization (kubernetes#1111)

* add german autoscaling localisation

* Update content/de/autoscaling.md

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

* Update content/de/autoscaling.md

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

* Update content/de/autoscaling.md

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

* change requests

* Update content/de/autoscaling.md

Signed-off-by: Noah Ispas <Noahispas@gmail.com>

Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com>

* corrects filename

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* correct wording (kubernetes#1355)

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* [localization/german] Add localization for API (kubernetes#1055)

* [localization/german] Add localization for API
Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

* fix filename

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* [DE] Localization of Blue Green Deployment (kubernetes#1342)

* first shot

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* localize headers

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* Update content/de/blue-green-deployment.md

Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>

* Update content/de/blue-green-deployment.md

Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>

* Update content/de/blue-green-deployment.md

Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>

* Update content/de/blue-green-deployment.md

Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>

* add change requests from Baris

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>
Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

* change every article state to completed

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* extend information about initializing members of german content

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>
Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: Baris Cubukcuoglu <cubukcuoglu.baris@gmail.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>
Co-authored-by: Dennis Groß <gdennis91@googlemail.com>
Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
Co-authored-by: Christian Hüning <christianhuening@users.noreply.github.com>
Co-authored-by: Oliver L <oliver@pattern.engineer>
Co-authored-by: Max Körbächer <m.koerbaecher@reply.de>
Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Co-authored-by: David Wagner <daw@dataone.de>
Co-authored-by: Baris Cubukcuoglu <cubukcuoglu.baris@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@artasparks @zacharysarah @jaredbhatti @bgrant0607 @pwittrock @steveperry-53