Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated addons section for cluster-components #1463

Merged
merged 1 commit into from
Dec 27, 2016

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented Oct 14, 2016

Fixed #1462.

Updates the description and link on http://kubernetes.io/docs/admin/cluster-components/ for the addons section. Content pasted below.

@lavalamp


addons

Addons are resources like ReplicationContoller and Services that implement cluster features. They don't run on the master VM, but currently the program that makes the API calls to manage these addon resources does run on the master VM. See: addon manager

Addon objects are created in the "kube-system" namespace except PersistentVolumes.


This change is Reviewable

@devin-donnelly
Copy link
Contributor

@lavalamp, is this accurate? Seems like a minor change.

the master VM, but currently the default setup scripts that make the API calls
to create these pods and services does run on the master VM. See:
[kube-master-addons](http://releases.k8s.io/HEAD/cluster/saltbase/salt/kube-master-addons/kube-master-addons.sh)
Addons are resources like ReplicationContoller and Services that implement cluster features.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is misleading. Addons run in pods on the cluster. Those pods may be managed by deployments, RCs, etc, but the sentence as written is going to really confuse people.


Addon objects are created in the "kube-system" namespace.
Addon objects are created in the "kube-system" namespace except `PersistentVolumes`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What addons make persistent volumes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this is misleading too. PersistentVolumes are also managed by Addon Manager, but they are not namespaced objects.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And currently no addon make persistent volumes.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 21, 2016
@jaredbhatti
Copy link
Contributor

@MrHohn - Once you address @lavalamp's issues I'll merge this PR.

@MrHohn MrHohn force-pushed the cluster-components-addons branch 2 times, most recently from 436ae7b to 8e9f2dc Compare November 22, 2016 06:09
@MrHohn
Copy link
Member Author

MrHohn commented Nov 22, 2016

Sorry for the delay. I updated the doc, PTAL

@devin-donnelly devin-donnelly merged commit f38055c into kubernetes:master Dec 27, 2016
@MrHohn MrHohn deleted the cluster-components-addons branch October 5, 2017 00:57
mikutas pushed a commit to mikutas/k8s-website that referenced this pull request Sep 22, 2022
* August Hero

This commit was authored by Catherine, but since she forgot DCO I'm signing
off on it (it's OK, she's a Buoyant employee [ ;) ]).

Signed-off-by: Flynn <flynn@buoyant.io>
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Co-authored-by: Flynn <flynn@buoyant.io>
Co-authored-by: Matei David <matei@buoyant.io>
Okabe-Junya pushed a commit to Okabe-Junya/website that referenced this pull request Dec 4, 2023
…n) (kubernetes#1463)

* Settings and initial contents for German localization (kubernetes#347)

* first shot

* WIP german contribution index file

* finalized contribution index, add de.toml

* add contentDir to de config section in config.toml

* change request from catherine

* finalizing style guide

* change request from David and Catherine

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* [de] Fix typo in _index.md

* first shot

* change requests

* [de] Add localization cloud computing (kubernetes#711)

* [de] Add localization cloud computing

* [de] Add missing title meta inf

* [de] Adjust wording in cloud computing

* [de] Adjust wording cloud computing

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

* update terms to completed (kubernetes#725)

* update terms to completed

* Update content/de/agile_software_development.md

Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>

* Update cloud_computing.md

Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>

* localize feedback section

* [de] Fix template title for agile software dev (kubernetes#731)

* Add german translation for API Gateway (kubernetes#732)

* Add german translation for API Gateway

Add german translation for API Gateway. Solves kubernetes#507

* Update api_gateway.md

fixed all found typos by

* Update api_gateway.md

small wording adjustment, changes state

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

* [de] Add localization for "abstraction"

* [de] Remove whitespaces

* [de] Remove redundant information

* [de] Rephrase sentence

* [de] Rephrase sentence

* [de] Remove white spaces

* [de] Add localization cloud native tech

* Incorporate suggested change

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

* Incorporate suggested change

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

* Incorporate suggested change

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

* Incorporate suggested change to title

* Update cloud_native_tech.md

* rename files, add semantic line breaks, empty lines (kubernetes#974)

* rename files, add semantic line breaks, empty lines

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* [DE] Take Over Cloud Native Security localization (kubernetes#990)

* add cloud native sec

Signed-off-by: Max Körbächer <m.koerbaecher@reply.de>
Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* edits, semantic line breaks

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* change requests from Jihoon

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* change requests from david

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* change requests from david

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* Update content/de/cloud-native-security.md

Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

* Update content/de/cloud-native-security.md

Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

Co-authored-by: Max Körbächer <m.koerbaecher@reply.de>
Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

* german localize cloud native apps (kubernetes#1085)

* add german localisation for cloud native apps

* add .md

* Apply suggestions from code review

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

* apply change requests - remove redundancy

* Update content/de/cloud-native-apps.md

Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

* Update content/de/cloud-native-apps.md

Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Co-authored-by: David Wagner <daw@dataone.de>
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

* [DE] Add german definition for canary deployment (kubernetes#1247)

* [de] Add german definition for canary deployment

Signed-off-by: Baris Cubukcuoglu <cubukcuoglu.baris@gmail.com>
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

* Update content/de/canary_deployment.md

Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

* Update content/de/canary_deployment.md

Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>

* Update content/de/canary_deployment.md

Signed-off-by: Noah Ispas <Noahispas@gmail.com>

Signed-off-by: Baris Cubukcuoglu <cubukcuoglu.baris@gmail.com>
Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

* german autoscaling localization (kubernetes#1111)

* add german autoscaling localisation

* Update content/de/autoscaling.md

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

* Update content/de/autoscaling.md

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

* Update content/de/autoscaling.md

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

* change requests

* Update content/de/autoscaling.md

Signed-off-by: Noah Ispas <Noahispas@gmail.com>

Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Co-authored-by: Noah Ispas <Noahispas@gmail.com>

* corrects filename

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* correct wording (kubernetes#1355)

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* [localization/german] Add localization for API (kubernetes#1055)

* [localization/german] Add localization for API
Co-authored-by: Noah Ispas <Noahispas@gmail.com>
Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

* fix filename

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* [DE] Localization of Blue Green Deployment (kubernetes#1342)

* first shot

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* localize headers

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* Update content/de/blue-green-deployment.md

Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>

* Update content/de/blue-green-deployment.md

Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>

* Update content/de/blue-green-deployment.md

Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>

* Update content/de/blue-green-deployment.md

Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>

* add change requests from Baris

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>
Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>

* change every article state to completed

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

* extend information about initializing members of german content

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>

Signed-off-by: Noah Ispas (iamNoah1) <noahispas@gmail.com>
Signed-off-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: Baris Cubukcuoglu <cubukcuoglu.baris@gmail.com>
Signed-off-by: Noah Ispas <Noahispas@gmail.com>
Co-authored-by: Dennis Groß <gdennis91@googlemail.com>
Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
Co-authored-by: Christian Hüning <christianhuening@users.noreply.github.com>
Co-authored-by: Oliver L <oliver@pattern.engineer>
Co-authored-by: Max Körbächer <m.koerbaecher@reply.de>
Co-authored-by: DaveVentura <47860237+DaveVentura@users.noreply.github.com>
Co-authored-by: David Wagner <daw@dataone.de>
Co-authored-by: Baris Cubukcuoglu <cubukcuoglu.baris@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants